Source/core/rendering/svg/RenderSVGResource.cpp - Issue 197213009: Remove unneeded check in requestPaintingResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGResource.cpp

Issue 197213009: Remove unneeded check in requestPaintingResource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Invert logic :) Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGResource.cpp

diff --git a/Source/core/rendering/svg/RenderSVGResource.cpp b/Source/core/rendering/svg/RenderSVGResource.cpp

index 0ee1191269dcf0c68afc7a0a9ce5f72852d05b10..eef60598685cc0f19c6b8fbcb8ba323e60a05371 100644

--- a/Source/core/rendering/svg/RenderSVGResource.cpp

+++ b/Source/core/rendering/svg/RenderSVGResource.cpp

@@ -81,8 +81,7 @@ static inline RenderSVGResource* requestPaintingResource(RenderSVGResourceMode m

bool applyToFill = mode == ApplyToFillMode;

SVGPaint::SVGPaintType paintType = applyToFill ? svgStyle->fillPaintType() : svgStyle->strokePaintType();

- if (paintType == SVGPaint::SVG_PAINTTYPE_NONE)

- return 0;

+ ASSERT(paintType != SVGPaint::SVG_PAINTTYPE_NONE);

Color color;

bool hasColor = false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »