Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 19721002: [telemetry] Add run_benchmark benchmarks for everything that runs on the bots. (Closed)

Created:
7 years, 5 months ago by dtu
Modified:
7 years, 5 months ago
Reviewers:
nduca, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

[telemetry] Add run_benchmark benchmarks for everything that runs on the bots. BUG=237412 TEST=None. R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212642

Patch Set 1 #

Total comments: 8

Patch Set 2 : keyboard cat #

Total comments: 2

Patch Set 3 : caturday in the park #

Patch Set 4 : longcat #

Total comments: 2

Patch Set 5 : I am Maru #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -98 lines) Patch
A tools/perf/benchmarks/blink_perf.py View 1 1 chunk +19 lines, -0 lines 0 comments Download
A tools/perf/benchmarks/dromaeo.py View 1 1 chunk +76 lines, -0 lines 0 comments Download
A tools/perf/benchmarks/image_decoding.py View 1 1 chunk +12 lines, -0 lines 0 comments Download
A tools/perf/benchmarks/memory.py View 1 chunk +16 lines, -0 lines 0 comments Download
D tools/perf/benchmarks/netsim_top25.py View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
A tools/perf/benchmarks/page_cycler.py View 1 2 3 4 1 chunk +91 lines, -0 lines 0 comments Download
A + tools/perf/benchmarks/robohornet_pro.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/perf/benchmarks/robohornetpro.py View 1 chunk +0 lines, -40 lines 0 comments Download
A tools/perf/benchmarks/startup_warm.py View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/perf/measurements/blink_perf.py View 1 2 chunks +42 lines, -36 lines 0 comments Download
M tools/perf/measurements/page_cycler.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dtu
I went through https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/master/factory/chromium_factory.py&q=AddTelemetryTest&sq=package:chromium&l=549 and converted every entry into a benchmark. Some have long or ...
7 years, 5 months ago (2013-07-18 01:11:41 UTC) #1
tonyg
https://codereview.chromium.org/19721002/diff/1/tools/perf/benchmarks/blink_perf.py File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/19721002/diff/1/tools/perf/benchmarks/blink_perf.py#newcode19 tools/perf/benchmarks/blink_perf.py:19: def _AddPage(path): I assume all this is duplicated with ...
7 years, 5 months ago (2013-07-18 01:39:00 UTC) #2
dtu
https://codereview.chromium.org/19721002/diff/1/tools/perf/benchmarks/blink_perf.py File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/19721002/diff/1/tools/perf/benchmarks/blink_perf.py#newcode19 tools/perf/benchmarks/blink_perf.py:19: def _AddPage(path): On 2013/07/18 01:39:00, tonyg wrote: > I ...
7 years, 5 months ago (2013-07-18 02:17:05 UTC) #3
tonyg
lgtm https://codereview.chromium.org/19721002/diff/8001/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py (right): https://codereview.chromium.org/19721002/diff/8001/tools/perf/benchmarks/page_cycler.py#newcode9 tools/perf/benchmarks/page_cycler.py:9: class PageCyclerBloat(test.Test): Oh, I remembered one more thing ...
7 years, 5 months ago (2013-07-18 02:32:39 UTC) #4
dtu
https://codereview.chromium.org/19721002/diff/8001/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py (right): https://codereview.chromium.org/19721002/diff/8001/tools/perf/benchmarks/page_cycler.py#newcode9 tools/perf/benchmarks/page_cycler.py:9: class PageCyclerBloat(test.Test): On 2013/07/18 02:32:39, tonyg wrote: > Oh, ...
7 years, 5 months ago (2013-07-18 20:39:43 UTC) #5
tonyg
On 2013/07/18 20:39:43, Dave Tu wrote: > https://codereview.chromium.org/19721002/diff/8001/tools/perf/benchmarks/page_cycler.py > File tools/perf/benchmarks/page_cycler.py (right): > > https://codereview.chromium.org/19721002/diff/8001/tools/perf/benchmarks/page_cycler.py#newcode9 ...
7 years, 5 months ago (2013-07-18 20:46:25 UTC) #6
dtu
On 2013/07/18 20:46:25, tonyg wrote: > On 2013/07/18 20:39:43, Dave Tu wrote: > > > ...
7 years, 5 months ago (2013-07-18 21:23:02 UTC) #7
dtu
7 years, 5 months ago (2013-07-18 21:23:11 UTC) #8
tonyg
lgtm https://codereview.chromium.org/19721002/diff/26001/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py (right): https://codereview.chromium.org/19721002/diff/26001/tools/perf/benchmarks/page_cycler.py#newcode9 tools/perf/benchmarks/page_cycler.py:9: class NetsimTop25(test.Test): Let's rename it PageCyclerNetsimTop25 for consistency. ...
7 years, 5 months ago (2013-07-18 21:32:33 UTC) #9
dtu
https://codereview.chromium.org/19721002/diff/26001/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py (right): https://codereview.chromium.org/19721002/diff/26001/tools/perf/benchmarks/page_cycler.py#newcode9 tools/perf/benchmarks/page_cycler.py:9: class NetsimTop25(test.Test): On 2013/07/18 21:32:34, tonyg wrote: > Let's ...
7 years, 5 months ago (2013-07-18 21:38:50 UTC) #10
dtu
7 years, 5 months ago (2013-07-19 20:36:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 manually as r212642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698