Simplify some old avatar menu button code.

chrome/browser/ui/view_ids.h

Index: chrome/browser/ui/view_ids.h
diff --git a/chrome/browser/ui/view_ids.h b/chrome/browser/ui/view_ids.h
index d166ed94cd73cf485b50320e94885d6cdb8c8ad2..4876665792c1be24d9d62bf3c46076a530debc73 100644
--- a/chrome/browser/ui/view_ids.h
+++ b/chrome/browser/ui/view_ids.h
@@ -22,7 +22,7 @@ enum ViewID {
   VIEW_ID_CLOSE_BUTTON,
   VIEW_ID_WINDOW_ICON,
   VIEW_ID_WINDOW_TITLE,
-  VIEW_ID_AVATAR_BUTTON,
+  VIEW_ID_PROFILE_INDICATOR_ICON,

[Peter Kasting, 2016/05/17 03:51:42]

Nit: I'm not in love with "profile indicator icon" as it seems verbose and
redundant yet vague, but I don't have a great idea myself.  I wish we could just
call it "incognito icon" but the teleported window case throws wrenches at that.
 Maybe just "profile icon" is as descriptive as this (i.e. not very) but at
least less verbose?

[Evan Stade, 2016/05/17 18:13:08]

I think profile icon and profile indicator icon are equally descriptive and the
former is more concise. But I prefer the latter because it's a more distinctive
name. The overuse and reuse of "avatar" was really confusing, hopefully using
"profile indicator" everywhere will be make this hard-to-describe piece of UI
more grep-able and more recognizable.

[Peter Kasting, 2016/05/18 02:44:00]

OK... I'm not strongly opposed, it just feels kind of like we're saying "hey,
like's call it the profile icon icon, because that's a more unique phrase than
profile icon".  It reads really oddly to me.

If you think it's better go with it.

   VIEW_ID_NEW_AVATAR_BUTTON,

[Peter Kasting, 2016/05/17 03:51:42]

Nit: Maybe just AVATAR_BUTTON now?

(Maybe we should get rid of "avatar" altogether since we use labels now and just
call it the "profile button" or something, but that's probably bigger than this
CL.  Although I guess even the phrasing "new avatar button" may be too big to
change in this CL since it encompasses view IDs, function names, variable names,
etc...)

[Evan Stade, 2016/05/17 18:13:08]

Done.

 
   // Tabs within a window/tab strip, counting from the left.