Simplify some old avatar menu button code.

chrome/browser/profiles/avatar_menu_desktop.cc

Index: chrome/browser/profiles/avatar_menu_desktop.cc
diff --git a/chrome/browser/profiles/avatar_menu_desktop.cc b/chrome/browser/profiles/avatar_menu_desktop.cc
index 8a7bca6a7ced30c2bf08e199e18386a07c333a4a..7d3bb0da8d4c3b96b5a65a3a1550b8901f389663 100644
--- a/chrome/browser/profiles/avatar_menu_desktop.cc
+++ b/chrome/browser/profiles/avatar_menu_desktop.cc
@@ -21,7 +21,6 @@ void AvatarMenu::GetImageForMenuButton(const base::FilePath& profile_path,
   ProfileAttributesEntry* entry;
   if (!g_browser_process->profile_manager()->GetProfileAttributesStorage().
           GetProfileAttributesWithPath(profile_path, &entry)) {
-    NOTREACHED();

[Peter Kasting, 2016/05/17 03:51:42]

So can this actually be reached, maybe for disk corruption or something?  Might
be nice to add a comment about what case results in this.

[Evan Stade, 2016/05/17 18:13:08]

I made this change because we already had a lot of checks and early returns for
this condition in other parts of the code, so it's not exactly a situation that
can't occur. It's simpler IMO to just call GetImageForMenuButton unconditionally
than to check this condition first. I believe it's explained by this
pre-existing comment, which I'll copy here.

// This can happen if the user deletes the current profile.

     return;
   }