Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1972023002:
Refactor chromium_tests tryserver.chromium.perf builder spec. (Closed)
DescriptionRefactor chromium_tests tryserver.chromium.perf builder spec.
Make it match the chromium.perf spec more closely.
Move some Windows bots from 32-bit to 64-bit to match chromium.perf.
BUG=611484
Committed: https://chromium.googlesource.com/chromium/tools/build/+/ed78cc14380f4f28e9bdd3f3a054a6e5dab7ff4a
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rename two bots that changed. #
Total comments: 2
Patch Set 3 : Fix master cfg #Patch Set 4 : Backpedal on the x64 so this can land. #Patch Set 5 : a #
Messages
Total messages: 30 (12 generated)
Description was changed from ========== Refactor chromium_tests tryserver.chromium.perf builder spec. ========== to ========== Refactor chromium_tests tryserver.chromium.perf builder spec. Move some Windows bots from 32-bit to 64-bit to match chromium.perf. ==========
dtu@chromium.org changed reviewers: + aiolos@chromium.org, prasadv@chromium.org
Description was changed from ========== Refactor chromium_tests tryserver.chromium.perf builder spec. Move some Windows bots from 32-bit to 64-bit to match chromium.perf. ========== to ========== Refactor chromium_tests tryserver.chromium.perf builder spec. Make it match the chromium.perf spec more closely. Move some Windows bots from 32-bit to 64-bit to match chromium.perf. ==========
Description was changed from ========== Refactor chromium_tests tryserver.chromium.perf builder spec. Make it match the chromium.perf spec more closely. Move some Windows bots from 32-bit to 64-bit to match chromium.perf. ========== to ========== Refactor chromium_tests tryserver.chromium.perf builder spec. Make it match the chromium.perf spec more closely. Move some Windows bots from 32-bit to 64-bit to match chromium.perf. BUG=611484 ==========
Sup.
https://codereview.chromium.org/1972023002/diff/1/scripts/slave/recipe_module... File scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py (right): https://codereview.chromium.org/1972023002/diff/1/scripts/slave/recipe_module... scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py:42: _AddTestSpec('win_8_perf_bisect', 'win') If we are planning to make this as x64 bit, then the bot name must be named as winx64_8_perf_bisect inconsistent with other x64 bots. Also in bisect recipe we decide the builder bot name based on bisect bot name, https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...
On 2016/05/25 21:35:26, prasadv wrote: > https://codereview.chromium.org/1972023002/diff/1/scripts/slave/recipe_module... > File scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py > (right): > > https://codereview.chromium.org/1972023002/diff/1/scripts/slave/recipe_module... > scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py:42: > _AddTestSpec('win_8_perf_bisect', 'win') > If we are planning to make this as x64 bit, then the bot name must be named as > winx64_8_perf_bisect inconsistent with other x64 bots. Also in bisect recipe we > decide the builder bot name based on bisect bot name, > https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re... Also please note if we change builder name, same name should be reflecred in https://chromeperf.appspot.com/edit_site_config?key=recipe_tester_director_map
When do I change the tester director map? https://codereview.chromium.org/1972023002/diff/1/scripts/slave/recipe_module... File scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py (right): https://codereview.chromium.org/1972023002/diff/1/scripts/slave/recipe_module... scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py:42: _AddTestSpec('win_8_perf_bisect', 'win') On 2016/05/25 21:35:25, prasadv wrote: > If we are planning to make this as x64 bit, then the bot name must be named as > winx64_8_perf_bisect inconsistent with other x64 bots. Also in bisect recipe we > decide the builder bot name based on bisect bot name, > https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re... Done.
https://codereview.chromium.org/1972023002/diff/20001/scripts/slave/recipe_mo... File scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py (right): https://codereview.chromium.org/1972023002/diff/20001/scripts/slave/recipe_mo... scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py:44: _AddTestSpec('winx64_8_perf_bisect', 'win') We should also rename the builder name on the master. And once the changes are effective on waterfall after master restart, we should change the tester map on dashboard.
Done, thanks! https://codereview.chromium.org/1972023002/diff/20001/scripts/slave/recipe_mo... File scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py (right): https://codereview.chromium.org/1972023002/diff/20001/scripts/slave/recipe_mo... scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py:44: _AddTestSpec('winx64_8_perf_bisect', 'win') On 2016/06/02 21:09:07, prasadv wrote: > We should also rename the builder name on the master. > And once the changes are effective on waterfall after master restart, we should > change the tester map on dashboard. > Done.
lgtm Please note the things todo: Before this CL lands: 1. Add entries for winx64_8_perf_bisect and winx64_fyi_perf_bisect in https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?q=win_fyi_perf_bi... 2. And entry for exclude winx64_fyi_perf_bisect from perf_try jobs. https://cs.chromium.org/chromium/src/tools/perf/core/trybot_command.py?q=win_... After CL lands and master restart: 1. Modify the config maps on the dashboard. https://chromeperf.appspot.com/edit_site_config?key=bisect_fyi_config_map: For FYI job on winx64_fyi_perf_bisect 2. https://chromeperf.appspot.com/edit_site_config?key=bisect_bot_map: To map winx64_8_perf_bisect 3.https://chromeperf.appspot.com/edit_site_config?key=recipe_tester_director_map: To enable buildbucket usage for both the bots.
On 2016/06/02 21:26:03, prasadv wrote: > lgtm > > Please note the things todo: > > Before this CL lands: > 1. Add entries for winx64_8_perf_bisect and winx64_fyi_perf_bisect in > https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?q=win_fyi_perf_bi... > > 2. And entry for exclude winx64_fyi_perf_bisect from perf_try jobs. > https://cs.chromium.org/chromium/src/tools/perf/core/trybot_command.py?q=win_... > > > After CL lands and master restart: > 1. Modify the config maps on the dashboard. > https://chromeperf.appspot.com/edit_site_config?key=bisect_fyi_config_map: For > FYI job on winx64_fyi_perf_bisect > > 2. https://chromeperf.appspot.com/edit_site_config?key=bisect_bot_map: To map > winx64_8_perf_bisect > > 3.https://chromeperf.appspot.com/edit_site_config?key=recipe_tester_director_map: > To enable buildbucket usage for both the bots. Woah. That is... a lot of things to keep track of. That's really an unacceptable number of configs. I think the sweet spot here is around 2 places you need to update to add a new bot, since it's a pretty common task. Unfortunately, the master, slave, and recipe configs already add up to 3! 4 on Android. Add these additional things, and it's like 8.
On 2016/06/02 22:00:25, dtu wrote: > On 2016/06/02 21:26:03, prasadv wrote: > > lgtm > > > > Please note the things todo: > > > > Before this CL lands: > > 1. Add entries for winx64_8_perf_bisect and winx64_fyi_perf_bisect in > > > https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?q=win_fyi_perf_bi... > > > > 2. And entry for exclude winx64_fyi_perf_bisect from perf_try jobs. > > > https://cs.chromium.org/chromium/src/tools/perf/core/trybot_command.py?q=win_... > > > > > > After CL lands and master restart: > > 1. Modify the config maps on the dashboard. > > https://chromeperf.appspot.com/edit_site_config?key=bisect_fyi_config_map: For > > FYI job on winx64_fyi_perf_bisect > > > > 2. https://chromeperf.appspot.com/edit_site_config?key=bisect_bot_map: To map > > winx64_8_perf_bisect > > > > > 3.https://chromeperf.appspot.com/edit_site_config?key=recipe_tester_director_map: > > To enable buildbucket usage for both the bots. > > Woah. That is... a lot of things to keep track of. That's really an unacceptable > number of configs. I think the sweet spot here is around 2 places you need to > update to add a new bot, since it's a pretty common task. Unfortunately, the > master, slave, and recipe configs already add up to 3! 4 on Android. Add these > additional things, and it's like 8. https://codereview.chromium.org/2046823002/ for the first two things.
The CQ bit was checked by dtu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972023002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
dtu@chromium.org changed reviewers: + stip@chromium.org
+stip, OWNERS ?
The CQ bit was checked by dtu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
rs-lgtm
The CQ bit was checked by dtu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from prasadv@chromium.org, stip@chromium.org Link to the patchset: https://codereview.chromium.org/1972023002/#ps80001 (title: "a")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Refactor chromium_tests tryserver.chromium.perf builder spec. Make it match the chromium.perf spec more closely. Move some Windows bots from 32-bit to 64-bit to match chromium.perf. BUG=611484 ========== to ========== Refactor chromium_tests tryserver.chromium.perf builder spec. Make it match the chromium.perf spec more closely. Move some Windows bots from 32-bit to 64-bit to match chromium.perf. BUG=611484 Committed: https://chromium.googlesource.com/chromium/tools/build/+/ed78cc14380f4f28e9bd... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/tools/build/+/ed78cc14380f4f28e9bd... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
