Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

Issue 1972023002: Refactor chromium_tests tryserver.chromium.perf builder spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@sizes
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
index bf4a44c2362c95f7b88d252a6c8a74438b05b014..7a026ca57b21e9bf42f092683b06bd81c1c6d3c0 100644
--- a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
@@ -37,12 +37,7 @@ def _BaseSpec(bot_type, chromium_apply_config, disable_tests,
}
-def _BuildSpec(platform, target_bits):
- if target_bits == 64:
- perf_id = platform
- else:
- perf_id = '%s-%d' % (platform, target_bits)
-
+def BuildSpec(perf_id, platform, target_bits):
if platform == 'android':
tests = []
else:
@@ -99,7 +94,12 @@ def _TestSpec(parent_builder, perf_id, platform, target_bits, max_battery_temp,
def _AddBuildSpec(name, platform, target_bits=64):
- SPEC['builders'][name] = _BuildSpec(platform, target_bits)
+ if target_bits == 64:
+ perf_id = platform
+ else:
+ perf_id = '%s-%d' % (platform, target_bits)
+
+ SPEC['builders'][name] = BuildSpec(perf_id, platform, target_bits)
assert target_bits not in _builders[platform]
_builders[platform][target_bits] = name
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698