Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1971953003: Warning instead of exception for cmake (Closed)

Created:
4 years, 7 months ago by liyuqian
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M platform_tools/android/apps/build.gradle View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
liyuqian
4 years, 7 months ago (2016-05-12 16:27:37 UTC) #3
bungeman-skia
Seems ok to me, as it gets past the blocker of just building the thing. ...
4 years, 7 months ago (2016-05-12 16:52:54 UTC) #4
djsollen
lgtm as a band-aid until we can remove the cmake dependency
4 years, 7 months ago (2016-05-12 16:56:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971953003/1
4 years, 7 months ago (2016-05-12 17:00:10 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 17:21:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7bde8f813fd02fc7b93a659c9f36019d8502a026

Powered by Google App Engine
This is Rietveld 408576698