platform_tools/android/apps/build.gradle - Issue 1971953003: Warning instead of exception for cmake

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/apps/build.gradle

Issue 1971953003: Warning instead of exception for cmake (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/apps/build.gradle

diff --git a/platform_tools/android/apps/build.gradle b/platform_tools/android/apps/build.gradle

index 40e085cf5f25c45681d118a81f5aeef511a6e9d3..901e3295eae0f23e87a11fd8b43115a1f83cae95 100644

--- a/platform_tools/android/apps/build.gradle

+++ b/platform_tools/android/apps/build.gradle

@@ -77,8 +77,7 @@ def getPathWithDeps(requireCMake = false) {

if (requireCMake) {

String cmakePath = getSDKPath() + "/cmake/bin"

if (!file(cmakePath).exists()) {

- throw new GradleScriptException("cmake not found! Please install the android SDK version" +

- " of cmake.", null);

+ logger.warn("cmake not found! Please install the android SDK version of cmake.");

}

if (!path.contains(cmakePath)) {

path = cmakePath + ":" + path

« no previous file with comments | « no previous file | no next file » | no next file with comments »