Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1971913002: Prototype for improved and generalized immediate event logging. (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prototype for improved and generalized immediate event logging. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -9 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M components/page_load_metrics/browser/page_load_metrics_observer.h View 1 chunk +31 lines, -0 lines 0 comments Download
M components/page_load_metrics/browser/page_load_metrics_observer.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Charlie Harrison
I'm happy with this approach. I wonder if some observers would like a "load complete" ...
4 years, 7 months ago (2016-05-13 14:47:45 UTC) #2
Bryan McQuade
On 2016/05/13 at 14:47:45, csharrison wrote: > I'm happy with this approach. > > I ...
4 years, 7 months ago (2016-05-13 15:12:28 UTC) #3
Bryan McQuade
4 years, 7 months ago (2016-05-13 15:14:21 UTC) #4
Message was sent while issue was closed. 
On 2016/05/13 at 15:12:28, Bryan McQuade wrote:
> On 2016/05/13 at 14:47:45, csharrison wrote:
> > I'm happy with this approach.
> > 
> > I wonder if some observers would like a "load complete" callback to log
everything, if they are not concerned about data loss before the load event.
> 
> Great, thanks! I wanted to change the issue description from 'prototype' so
I've opened a new issue for this: https://codereview.chromium.org/1975963003.
I'll close thi one out.

RE: adding a load complete callback, for now, this new class is intended to be
used in collaboration with the existing PageLoadMetricsObserver class, so anyone
that wants to log some metrics in OnComplete can continue to do so in their PLMO
implementation.

Powered by Google App Engine
This is Rietveld 408576698