Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 1971913002: Prototype for improved and generalized immediate event logging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index c15c30a5e78b7d7966b14b61492e7e18a707371e..45b44f320f2e6ea05843d1fc100bf97aa43c2e87 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -135,14 +135,16 @@ CorePageLoadMetricsObserver::~CorePageLoadMetricsObserver() {}
void CorePageLoadMetricsObserver::OnTimingUpdate(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- if (!logged_first_contentful_paint_from_timing_update_ &&
- !timing.first_contentful_paint.is_zero()) {
- if (WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
- info)) {
- PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintImmediate,
- timing.first_contentful_paint);
- }
- logged_first_contentful_paint_from_timing_update_ = true;
+ event_observer_.HandleTimingUpdate(timing, info);
+}
+
+void CorePageLoadMetricsObserver::EventObserver::OnFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) {
+ if (WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
+ info)) {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintImmediate,
+ timing.first_contentful_paint);
}
}

Powered by Google App Engine
This is Rietveld 408576698