[MediaRouter] Update JoinRoute behavior to allow non-local routes.

[MediaRouter] Update JoinRoute behavior to allow non-local routes.

Change https://codereview.chromium.org/1911183002 rejects JoinRoute requests when there are no local routes.  This breaks certain use cases for Cast.

This relaxes the check to forward requests to the MRPM when there is any route (local or non-local).

Long term, individual routes should be marked joinable or non-joinable so the optimization can be made precise.

BUG=610797
Committed: https://crrev.com/0ae252e8c2280bacd2d75c280dc0440f97277e37
Cr-Commit-Position: refs/heads/master@{#393330}

[mark a. foltz, 2016-05-11 21:10:28]

Description was changed from

==========
[MediaRouter] Update JoinRoute behavior to allow non-local routes.


BUG=
==========

to

==========
[MediaRouter] Update JoinRoute behavior to allow non-local routes.

Change https://codereview.chromium.org/1911183002 rejects JoinRoute requests
when there are no local routes.  This breaks certain use cases for Cast.

This relaxes the check to forward requests to the MRPM when there is any route
(local or non-local).

Long term, individual routes should be marked joinable or non-joinable so the
optimization can be made precise.

BUG=610797
==========

[mark a. foltz, 2016-05-11 21:10:28]

mfoltz@chromium.org changed reviewers:
+ imcheng@chromium.org

[imcheng, 2016-05-12 00:22:21]

https://codereview.chromium.org/1971893002/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/media_router_base.cc (right):

https://codereview.chromium.org/1971893002/diff/1/chrome/browser/media/router...
chrome/browser/media/router/media_router_base.cc:30: has_route =
!routes.empty();
nit: add a TODO here to optimize this to only check for joinable routexs.

As a side note, I wonder if |joinable_route_ids| can be reused for this purpose.
Currently, if there is no MediaSource associated with a routes query, we return
an empty joinable route id list. Perhaps that could be changed to return routes
that are joinable via any means, but I will have go back and check if it will
break the UI.

[imcheng, 2016-05-12 00:22:28]

lgtm

[mark a. foltz, 2016-05-12 18:38:43]

https://codereview.chromium.org/1971893002/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/media_router_base.cc (right):

https://codereview.chromium.org/1971893002/diff/1/chrome/browser/media/router...
chrome/browser/media/router/media_router_base.cc:30: has_route =
!routes.empty();
On 2016/05/12 at 00:22:20, imcheng wrote:
> nit: add a TODO here to optimize this to only check for joinable routexs.

Done.

> As a side note, I wonder if |joinable_route_ids| can be reused for this
purpose. Currently, if there is no MediaSource associated with a routes query,
we return an empty joinable route id list. Perhaps that could be changed to
return routes that are joinable via any means, but I will have go back and check
if it will break the UI.

Filed crbug.com/611486 and added to TODO.

[mark a. foltz, 2016-05-12 18:38:53]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-05-12 18:38:53]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1971893002/#ps20001
(title: "Respond to imcheng@ comment")

[commit-bot: I haz the power, 2016-05-12 18:39:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971893002/20001

[commit-bot: I haz the power, 2016-05-12 19:31:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 19:32:06]

Description was changed from

==========
[MediaRouter] Update JoinRoute behavior to allow non-local routes.

Change https://codereview.chromium.org/1911183002 rejects JoinRoute requests
when there are no local routes.  This breaks certain use cases for Cast.

This relaxes the check to forward requests to the MRPM when there is any route
(local or non-local).

Long term, individual routes should be marked joinable or non-joinable so the
optimization can be made precise.

BUG=610797
==========

to

==========
[MediaRouter] Update JoinRoute behavior to allow non-local routes.

Change https://codereview.chromium.org/1911183002 rejects JoinRoute requests
when there are no local routes.  This breaks certain use cases for Cast.

This relaxes the check to forward requests to the MRPM when there is any route
(local or non-local).

Long term, individual routes should be marked joinable or non-joinable so the
optimization can be made precise.

BUG=610797

Committed: https://crrev.com/0ae252e8c2280bacd2d75c280dc0440f97277e37
Cr-Commit-Position: refs/heads/master@{#393330}
==========

[commit-bot: I haz the power, 2016-05-12 19:32:07]

Patchset 2 (id:??) landed as
https://crrev.com/0ae252e8c2280bacd2d75c280dc0440f97277e37
Cr-Commit-Position: refs/heads/master@{#393330}