chrome/browser/media/router/mojo/media_router_mojo_impl.cc - Issue 1971893002: [MediaRouter] Update JoinRoute behavior to allow non-local routes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl.cc

Issue 1971893002: [MediaRouter] Update JoinRoute behavior to allow non-local routes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to imcheng@ comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/media_router_base.cc ('k') | chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/mojo/media_router_mojo_impl.cc

diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc

index c30797a99dc8ac27b5308f6b415a333dcb477fe4..716964882c31102ab059a30d1db8215f076170da 100644

--- a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc

+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc

@@ -345,8 +345,8 @@ void MediaRouterMojoImpl::JoinRoute(

DVLOG_WITH_INSTANCE(1) << "Invalid origin: " << origin;

error_result = RouteRequestResult::FromError(

"Invalid origin", RouteRequestResult::INVALID_ORIGIN);

- } else if (!HasLocalRoute()) {

- DVLOG_WITH_INSTANCE(1) << "No local routes";

+ } else if (!HasJoinableRoute()) {

+ DVLOG_WITH_INSTANCE(1) << "No joinable routes";

error_result = RouteRequestResult::FromError(

"Route not found", RouteRequestResult::ROUTE_NOT_FOUND);

}