v8 gn build: Support buildling Win snapshots from OS X.

v8 gn build: Support buildling Win snapshots from OS X.

closed in favor of https://codereview.chromium.org/1996513005

BUG=chromium:495204
LOG=N

[Nico, 2016-05-11 12:53:10]

thakis@chromium.org changed reviewers:
+ jochen@chromium.org

[Nico, 2016-05-11 12:53:10]

https://codereview.chromium.org/1971723002/diff/1/snapshot_toolchain.gni
File snapshot_toolchain.gni (right):

https://codereview.chromium.org/1971723002/diff/1/snapshot_toolchain.gni#newc...
snapshot_toolchain.gni:43: snapshot_toolchain =
"//build/toolchain/mac:clang_$target_cpu"
We currently only have a mac:clang_x64 toolchain, no mac:clang_x86. We could add
one, but for now I have an assert that target=win host=mac target_cpu=x86 isn't
supported and that folks who want to do cross builds like this (which don't yet
work for other reasons anyhow) should do 64-bit builds.

[jochen (gone - plz use gerrit), 2016-05-11 12:57:13]

dpranke is just rewriting this file, please hold off a bit

[Nico, 2016-05-11 13:00:36]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Nico, 2016-05-11 13:00:36]

dpranke: I hear you're rewriting this file; please keep this use case in mind
while doing so.

[Dirk Pranke, 2016-05-11 16:01:04]

On 2016/05/11 13:00:36, Nico wrote:
> dpranke: I hear you're rewriting this file; please keep this use case in mind
> while doing so.

In https://codereview.chromium.org/1969693002/ I changed snapshot_toolchain
to be a build arg, so you could get what you want by setting the arg explicitly,
but not by default. I can certainly add the default.

[Nico, 2016-05-11 16:06:59]

That'd be nice. Looks like I could rebase this patch over your change without
problems too though.

[Dirk Pranke, 2016-05-11 16:10:43]

On 2016/05/11 16:06:59, Nico wrote:
> That'd be nice. Looks like I could rebase this patch over your change without
> problems too though.

Yeah, but hold off on doing that, as it turns out that my patch by itself may
not be enough to make cros happy, so I need to stare at it some more.

[Nico, 2016-05-11 16:12:46]

If https://codereview.chromium.org/1969693002/ needs more time we could land
this change to the file first…

[Dirk Pranke, 2016-05-15 01:42:29]

On 2016/05/11 16:12:46, Nico wrote:
> If https://codereview.chromium.org/1969693002/ needs more time we could land
> this change to the file first…

I plan to add this fix as part of https://codereview.chromium.org/1979883002/
now.

[Nico, 2016-05-27 14:35:43]

Description was changed from

==========
v8 gn build: Support buildling Win snapshots from OS X.

BUG=chromium:495204
LOG=N
==========

to

==========
v8 gn build: Support buildling Win snapshots from OS X.

closed in favor of https://codereview.chromium.org/1996513005

BUG=chromium:495204
LOG=N
==========