Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1996513005:
Try to reland v8_snapshot GN build changes, take #3 (Closed)
|
Created:
4 years, 7 months ago by Dirk Pranke Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com, stevenjb, llozano Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionTry to reland v8_snapshot GN build changes, take #3
This patch re-lands #36341 with another fix to make
the amd64-generic build work as well.
R=machenbach@chromium.org, hablich@chromium.org, adamk@chromium.org
BUG=608596, 595653
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg
Committed: https://crrev.com/2e0bd36d278278e1ebede35a2a6d3e6399250ee6
Cr-Commit-Position: refs/heads/master@{#36390}
Patch Set 1 #Patch Set 2 : fix x64 as well #Messages
Total messages: 23 (12 generated)
Description was changed from ========== Try to reland v8_snapshot GN build changes, take #3 This patch re-lands #36341 with another fix to make the amd64-generic build work as well. TBR=machenbach@chromium.org BUG=608596, 595653 ========== to ========== Try to reland v8_snapshot GN build changes, take #3 This patch re-lands #36341 with another fix to make the amd64-generic build work as well. TBR=machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg ==========
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996513005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996513005/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Try to reland v8_snapshot GN build changes, take #3 This patch re-lands #36341 with another fix to make the amd64-generic build work as well. TBR=machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg ========== to ========== Try to reland v8_snapshot GN build changes, take #3 This patch re-lands #36341 with another fix to make the amd64-generic build work as well. R=machenbach@chromium.org, hablich@chromium.org, adamk@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg ==========
dpranke@chromium.org changed reviewers: + adamk@chromium.org, hablich@chromium.org
machenbach@, adamk@, hablich@ can one of you review this and/or CQ it if it looks good to you?
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996513005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996513005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996513005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996513005/20001
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996513005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996513005/20001
Message was sent while issue was closed.
Description was changed from ========== Try to reland v8_snapshot GN build changes, take #3 This patch re-lands #36341 with another fix to make the amd64-generic build work as well. R=machenbach@chromium.org, hablich@chromium.org, adamk@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg ========== to ========== Try to reland v8_snapshot GN build changes, take #3 This patch re-lands #36341 with another fix to make the amd64-generic build work as well. R=machenbach@chromium.org, hablich@chromium.org, adamk@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Try to reland v8_snapshot GN build changes, take #3 This patch re-lands #36341 with another fix to make the amd64-generic build work as well. R=machenbach@chromium.org, hablich@chromium.org, adamk@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg ========== to ========== Try to reland v8_snapshot GN build changes, take #3 This patch re-lands #36341 with another fix to make the amd64-generic build work as well. R=machenbach@chromium.org, hablich@chromium.org, adamk@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg Committed: https://crrev.com/2e0bd36d278278e1ebede35a2a6d3e6399250ee6 Cr-Commit-Position: refs/heads/master@{#36390} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2e0bd36d278278e1ebede35a2a6d3e6399250ee6 Cr-Commit-Position: refs/heads/master@{#36390} |
