Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1971693002: [wasm] Introduce custom asm.js bytecodes for double->int conversions. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Introduce custom asm.js bytecodes for double->int conversions. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/297373019069bc410eb1299b602e10ba7843edb2 Cr-Commit-Position: refs/heads/master@{#36164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -32 lines) Patch
M src/compiler/wasm-compiler.h View 2 chunks +10 lines, -5 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 7 chunks +34 lines, -20 lines 0 comments Download
M src/wasm/asm-wasm-builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-asmjs.cc View 1 chunk +40 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1968943002 Patch 1

Messages

Total messages: 7 (2 generated)
titzer
4 years, 7 months ago (2016-05-11 08:58:08 UTC) #1
ahaas
lgtm
4 years, 7 months ago (2016-05-11 09:27:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971693002/1
4 years, 7 months ago (2016-05-11 09:29:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 09:31:39 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 09:32:01 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/297373019069bc410eb1299b602e10ba7843edb2
Cr-Commit-Position: refs/heads/master@{#36164}

Powered by Google App Engine
This is Rietveld 408576698