[wasm] Introduce custom asm.js bytecodes for loads and stores.

[wasm] Introduce custom asm.js bytecodes for loads and stores.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/f00efdaed52a9a5311cfe8ced73218f71eeed02e
Cr-Commit-Position: refs/heads/master@{#36169}

[ahaas, 2016-05-11 11:10:14]

https://codereview.chromium.org/1968943002/diff/1/test/cctest/wasm/test-run-w...
File test/cctest/wasm/test-run-wasm-asmjs.cc (right):

https://codereview.chromium.org/1968943002/diff/1/test/cctest/wasm/test-run-w...
test/cctest/wasm/test-run-wasm-asmjs.cc:178: TEST(Run_Wasm_StoreMemI32_oob_asm)
{
Is there a reason why you skip the tests for the other new bytecodes?

[titzer, 2016-05-11 11:19:09]

On 2016/05/11 11:10:14, ahaas wrote:
>
https://codereview.chromium.org/1968943002/diff/1/test/cctest/wasm/test-run-w...
> File test/cctest/wasm/test-run-wasm-asmjs.cc (right):
> 
>
https://codereview.chromium.org/1968943002/diff/1/test/cctest/wasm/test-run-w...
> test/cctest/wasm/test-run-wasm-asmjs.cc:178:
TEST(Run_Wasm_StoreMemI32_oob_asm)
> {
> Is there a reason why you skip the tests for the other new bytecodes?

Pretty much just laziness. The CheckedLoad/CheckedStore operators are tested
more extensively in test-run-load-store.cc, but I can add some tests to cover
the WASM bytecodes here if you insist.

[ahaas, 2016-05-11 11:34:40]

On 2016/05/11 at 11:19:09, titzer wrote:
> On 2016/05/11 11:10:14, ahaas wrote:
> >
https://codereview.chromium.org/1968943002/diff/1/test/cctest/wasm/test-run-w...
> > File test/cctest/wasm/test-run-wasm-asmjs.cc (right):
> > 
> >
https://codereview.chromium.org/1968943002/diff/1/test/cctest/wasm/test-run-w...
> > test/cctest/wasm/test-run-wasm-asmjs.cc:178:
TEST(Run_Wasm_StoreMemI32_oob_asm)
> > {
> > Is there a reason why you skip the tests for the other new bytecodes?
> 
> Pretty much just laziness. The CheckedLoad/CheckedStore operators are tested
more extensively in test-run-load-store.cc, but I can add some tests to cover
the WASM bytecodes here if you insist.

lgtm, I don't insist.

[titzer, 2016-05-11 11:48:41]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-05-11 11:48:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968943002/1

[commit-bot: I haz the power, 2016-05-11 11:50:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-11 11:51:01]

Description was changed from

==========
[wasm] Introduce custom asm.js bytecodes for loads and stores.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=
==========

to

==========
[wasm] Introduce custom asm.js bytecodes for loads and stores.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/f00efdaed52a9a5311cfe8ced73218f71eeed02e
Cr-Commit-Position: refs/heads/master@{#36169}
==========

[commit-bot: I haz the power, 2016-05-11 11:51:02]

Patchset 1 (id:??) landed as
https://crrev.com/f00efdaed52a9a5311cfe8ced73218f71eeed02e
Cr-Commit-Position: refs/heads/master@{#36169}