Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: src/debug/liveedit.h

Issue 1971683002: [debugger] Refactor LiveEdit function info collection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/liveedit.h
diff --git a/src/debug/liveedit.h b/src/debug/liveedit.h
index 4edd5831823beaf6ef3bd92cb0cab47ce3bab01e..38395981bac5300a279a48cdfb29ac977fffc671 100644
--- a/src/debug/liveedit.h
+++ b/src/debug/liveedit.h
@@ -32,25 +32,18 @@ namespace v8 {
namespace internal {
// This class collects some specific information on structure of functions
-// in a particular script. It gets called from compiler all the time, but
-// actually records any data only when liveedit operation is in process;
-// in any other time this class is very cheap.
+// in a particular script.
//
// The primary interest of the Tracker is to record function scope structures
-// in order to analyze whether function code maybe safely patched (with new
+// in order to analyze whether function code may be safely patched (with new
// code successfully reading existing data from function scopes). The Tracker
// also collects compiled function codes.
-class LiveEditFunctionTracker {
+class LiveEditFunctionTracker : AllStatic {
Yang 2016/05/11 07:29:09 As previously described, we should merge the funct
jgruber1 2016/05/12 12:30:25 Done.
public:
- explicit LiveEditFunctionTracker(Isolate* isolate, FunctionLiteral* fun);
- ~LiveEditFunctionTracker();
- void RecordFunctionInfo(Handle<SharedFunctionInfo> info,
- FunctionLiteral* lit, Zone* zone);
+ static void Collect(Handle<Script> script, ParseInfo* parse_info,
+ Isolate* isolate);
static bool IsActive(Isolate* isolate);
-
- private:
- Isolate* isolate_;
};

Powered by Google App Engine
This is Rietveld 408576698