[debugger] Refactor LiveEdit function info collection

src/compiler.cc

Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 18564ac0f9578f51a9aac39ae5c7ac35f1ceb246..318478996b51d2eb02db5627a307f16fe5d2206b 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -1032,7 +1032,6 @@ Handle<SharedFunctionInfo> CompileToplevel(CompilationInfo* info) {
     DCHECK(!info->is_debug() || !parse_info->allow_lazy_parsing());
 
     FunctionLiteral* lit = parse_info->literal();
-    LiveEditFunctionTracker live_edit_tracker(isolate, lit);
 
     // Measure how long it takes to do the compilation; only take the
     // rest of the function into account to avoid overlap with the
@@ -1078,8 +1077,6 @@ Handle<SharedFunctionInfo> CompileToplevel(CompilationInfo* info) {
 
     if (!script.is_null())
       script->set_compilation_state(Script::COMPILATION_STATE_COMPILED);
-
-    live_edit_tracker.RecordFunctionInfo(result, lit, info->zone());
   }
 
   return result;
@@ -1256,6 +1253,8 @@ bool Compiler::CompileForLiveEdit(Handle<Script> script) {
     return false;
   }
 
+  LiveEditFunctionTracker::Collect(script, &parse_info, isolate);

[Yang, 2016/05/11 07:29:09]

The caller of CompileForLiveEdit (LiveEdit::GatherCompileInfo) sets the
FunctionInfoListener onto the isolate for LiveEditFunctionTracker to call into.
This should not be necessary. Instead, let's fold the functionality of
LiveEditFunctionTracker and FunctionInfoListener into LiveEditFunctionVisitor.
LiveEdit::GatherCompileInfo should just pass in an instance of
LiveEditFunctionVisitor into here.

LiveEditFunctionVisitor would have a Collect method, and hide all the visit
methods as private.

[jgruber1, 2016/05/12 12:30:25]

Done.
We can't hide visit methods since they're used by node::Accept().

+
   // Check postconditions on success.
   DCHECK(!isolate->has_pending_exception());
   return true;
@@ -1586,7 +1585,6 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfo(
   if (outer_info->will_serialize()) info.PrepareForSerializing();
   if (outer_info->is_debug()) info.MarkAsDebug();
 
-  LiveEditFunctionTracker live_edit_tracker(isolate, literal);
   // Determine if the function can be lazily compiled. This is necessary to
   // allow some of our builtin JS files to be lazily compiled. These
   // builtins cannot be handled lazily by the parser, since we have to know
@@ -1635,7 +1633,6 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfo(
 
   if (maybe_existing.is_null()) {
     RecordFunctionCompilation(Logger::FUNCTION_TAG, &info);
-    live_edit_tracker.RecordFunctionInfo(result, literal, info.zone());
   }
 
   return result;