Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1971623002: LogDog: Enable Coordinator to load project configs (Closed)

Created:
4 years, 7 months ago by dnj
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@logdog-project-config
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Enable Coordinator to load project configs Add facilities to Coordinator service to load project and service configurations. Endpoints will not use any new configurations yet. BUG= Committed: https://github.com/luci/luci-go/commit/6dbddb374dacb9f054c38c9164df04cc7b17cd98

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated patchset dependency #

Patch Set 3 : Minor comments/updates #

Patch Set 4 : rebase #

Patch Set 5 : rebase (auto) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -12 lines) Patch
M appengine/logdog/coordinator/config/projects.go View 1 2 3 chunks +44 lines, -1 line 0 comments Download
M appengine/logdog/coordinator/coordinatorTest/context.go View 1 1 chunk +4 lines, -2 lines 0 comments Download
M appengine/logdog/coordinator/coordinatorTest/service.go View 1 2 3 chunks +13 lines, -5 lines 0 comments Download
M appengine/logdog/coordinator/project.go View 1 2 chunks +23 lines, -0 lines 0 comments Download
M appengine/logdog/coordinator/service.go View 5 chunks +54 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
dnj (Google)
PTAL. Nothing actually *uses* this yet, but small CLs :)
4 years, 7 months ago (2016-05-11 01:26:55 UTC) #2
nodir
lgtm https://codereview.chromium.org/1971623002/diff/1/appengine/logdog/coordinator/config/projects.go File appengine/logdog/coordinator/config/projects.go (right): https://codereview.chromium.org/1971623002/diff/1/appengine/logdog/coordinator/config/projects.go#newcode34 appengine/logdog/coordinator/config/projects.go:34: // ProjectConfig loads the the project config protobuf ...
4 years, 7 months ago (2016-05-18 16:05:35 UTC) #5
dnj (Google)
https://codereview.chromium.org/1971623002/diff/1/appengine/logdog/coordinator/config/projects.go File appengine/logdog/coordinator/config/projects.go (right): https://codereview.chromium.org/1971623002/diff/1/appengine/logdog/coordinator/config/projects.go#newcode34 appengine/logdog/coordinator/config/projects.go:34: // ProjectConfig loads the the project config protobuf from ...
4 years, 7 months ago (2016-05-18 16:46:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971623002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971623002/80001
4 years, 7 months ago (2016-05-19 23:02:53 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:06:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://github.com/luci/luci-go/commit/6dbddb374dacb9f054c38c9164df04cc7b17cd98

Powered by Google App Engine
This is Rietveld 408576698