LogDog: enable services to fetch project configs

LogDog: Enable services to fetch project configs

Update the microservice configuration layer to load per-project
configurations.

This is a staging CL; nothing currently uses this facility.

BUG=

Committed: https://github.com/luci/luci-go/commit/e9e25279d5f5c869e21c713467a56993e7c26f1e

[dnj (Google), 2016-05-11 01:43:36]

dnj@google.com changed reviewers:
+ dnj@google.com, nodir@chromium.org, vadimsh@chromium.org

[dnj (Google), 2016-05-11 01:43:37]

PTAL! This uses proccache, hopefully well. It is also not used yet, but small
CLs :)

[dnj, 2016-05-17 20:31:30]

Description was changed from

==========
LogDog: enable services to fetch project configs

BUG=
==========

to

==========
LogDog: Enable services to fetch project configs

Update the microservice configuration layer to load per-project
configurations.

This is a staging CL; nothing currently uses this facility.

BUG=
==========

[nodir, 2016-05-18 16:25:52]

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
File server/internal/logdog/service/config/config.go (right):

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:32: ProjectID string
Better call it AppID so it is unambiguous. Luci config actually uses term
"project id", not "project name"

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:153: projectID := m.o.ProjectID
This is app id

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:177: "path":       configPath,
Sort?

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:186: "path":         
configPath,
Sort?

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
File server/internal/logdog/service/service.go (right):

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/service.go:246: "Specify the cloud project ID
that this instance is supporting. If empty, the project ID "+
Please rename to "app-id". Gcp SDK calls it "app" too

[dnj (Google), 2016-05-18 16:50:31]

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
File server/internal/logdog/service/config/config.go (right):

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:32: ProjectID string
On 2016/05/18 16:25:51, nodir wrote:
> Better call it AppID so it is unambiguous. Luci config actually uses term
> "project id", not "project name"

I'm using the term, "project ID", here, which is consistent with LUCI-config
(projects/<project-id>). AppID == ProjectID, I feel, is a GAE implementation
detail that I don't need to propagate outside of GAE code.

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:153: projectID := m.o.ProjectID
On 2016/05/18 16:25:51, nodir wrote:
> This is app id

Acknowledged.

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:177: "path":       configPath,
On 2016/05/18 16:25:51, nodir wrote:
> Sort?

I don't think you need to pay so much attention to the order of map keys. I'm
fine with this being not specifically ordered.

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:186: "path":         
configPath,
On 2016/05/18 16:25:51, nodir wrote:
> Sort?

Acknowledged.

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
File server/internal/logdog/service/service.go (right):

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/service.go:246: "Specify the cloud project ID
that this instance is supporting. If empty, the project ID "+
On 2016/05/18 16:25:51, nodir wrote:
> Please rename to "app-id". Gcp SDK calls it "app" too 

I'm using the luci-config concept here, not the GAE one.

[nodir, 2016-05-18 17:02:19]

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
File server/internal/logdog/service/config/config.go (right):

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:32: ProjectID string
On 2016/05/18 16:50:31, dnj (Google) wrote:
> On 2016/05/18 16:25:51, nodir wrote:
> > Better call it AppID so it is unambiguous. Luci config actually uses term
> > "project id", not "project name"
> 
> I'm using the term, "project ID", here, which is consistent with LUCI-config
> (projects/<project-id>). AppID == ProjectID, I feel, is a GAE implementation
> detail that I don't need to propagate outside of GAE code.

I don't understand. This is app id, see how is it used

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
File server/internal/logdog/service/service.go (right):

https://codereview.chromium.org/1970463005/diff/40001/server/internal/logdog/...
server/internal/logdog/service/service.go:246: "Specify the cloud project ID
that this instance is supporting. If empty, the project ID "+
On 2016/05/18 16:50:31, dnj (Google) wrote:
> On 2016/05/18 16:25:51, nodir wrote:
> > Please rename to "app-id". Gcp SDK calls it "app" too 
> 
> I'm using the luci-config concept here, not the GAE one.

Then why it says cloud project and why this flag is mapped to a field which is
populated with GCE metadata. I think it is so confusing even you confuse it

[nodir, 2016-05-18 17:05:56]

https://codereview.chromium.org/1970463005/diff/60001/server/internal/logdog/...
File server/internal/logdog/service/config/config.go (right):

https://codereview.chromium.org/1970463005/diff/60001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:177: "hash":      
cfg.ContentHash,
This is not sorted?

[dnj (Google), 2016-05-18 17:21:29]

https://codereview.chromium.org/1970463005/diff/60001/server/internal/logdog/...
File server/internal/logdog/service/config/config.go (right):

https://codereview.chromium.org/1970463005/diff/60001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:177: "hash":      
cfg.ContentHash,
On 2016/05/18 17:05:56, nodir wrote:
> This is not sorted?

This is the order that I want it to be in. I don't want to sort it. This reads
nicer, and it doesn't really matter, so I am okay with a little personal
preference here.

[nodir, 2016-05-18 18:01:10]

https://codereview.chromium.org/1970463005/diff/60001/server/internal/logdog/...
File server/internal/logdog/service/config/config.go (right):

https://codereview.chromium.org/1970463005/diff/60001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:177: "hash":      
cfg.ContentHash,
On 2016/05/18 17:21:29, dnj (Google) wrote:
> On 2016/05/18 17:05:56, nodir wrote:
> > This is not sorted?
> 
> This is the order that I want it to be in. I don't want to sort it. This reads
> nicer, and it doesn't really matter, so I am okay with a little personal
> preference here.

Ah, sorry I didn't read your reply to my previous comment about this

[nodir, 2016-05-18 23:40:08]

I am not sure you saw message #6

[dnj (Google), 2016-05-19 01:00:33]

Okay, went with "service ID".

[nodir, 2016-05-19 01:36:34]

lgtm

https://codereview.chromium.org/1970463005/diff/80001/server/internal/logdog/...
File server/internal/logdog/service/config/config.go (right):

https://codereview.chromium.org/1970463005/diff/80001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:28: // ServiceID is the
service's ID. This is used to load project configurations,
"ServiceID is used to load ...

https://codereview.chromium.org/1970463005/diff/80001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:155: return nil, errors.New("no
app ID specified")
no service ID specified

[dnj (Google), 2016-05-19 02:10:57]

https://codereview.chromium.org/1970463005/diff/80001/server/internal/logdog/...
File server/internal/logdog/service/config/config.go (right):

https://codereview.chromium.org/1970463005/diff/80001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:28: // ServiceID is the
service's ID. This is used to load project configurations,
On 2016/05/19 01:36:34, nodir wrote:
> "ServiceID is used to load ...

Done.

https://codereview.chromium.org/1970463005/diff/80001/server/internal/logdog/...
server/internal/logdog/service/config/config.go:155: return nil, errors.New("no
app ID specified")
On 2016/05/19 01:36:34, nodir wrote:
> no service ID specified

Done.

[dnj (Google), 2016-05-19 23:07:08]

The CQ bit was checked by dnj@google.com

[dnj (Google), 2016-05-19 23:07:08]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/1970463005/#ps140001
(title: "Updated patchset dependency")

[commit-bot: I haz the power, 2016-05-19 23:07:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970463005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970463005/140001

[commit-bot: I haz the power, 2016-05-19 23:11:10]

Description was changed from

==========
LogDog: Enable services to fetch project configs

Update the microservice configuration layer to load per-project
configurations.

This is a staging CL; nothing currently uses this facility.

BUG=
==========

to

==========
LogDog: Enable services to fetch project configs

Update the microservice configuration layer to load per-project
configurations.

This is a staging CL; nothing currently uses this facility.

BUG=

Committed:
https://github.com/luci/luci-go/commit/e9e25279d5f5c869e21c713467a56993e7c26f1e
==========

[commit-bot: I haz the power, 2016-05-19 23:11:11]

Committed patchset #8 (id:140001) as
https://github.com/luci/luci-go/commit/e9e25279d5f5c869e21c713467a56993e7c26f1e