Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1971603002: Bind former arrow function in connection.js to this. (Closed)

Created:
4 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bind former arrow function in connection.js to this. https://codereview.chromium.org/1960413002 replaced an arrow function with a regular function in connection.js however this function needs to be explicitly bound to |this|. BUG=610567 Committed: https://crrev.com/74030c0b688d538776300991ad778ae0b095a15e Cr-Commit-Position: refs/heads/master@{#392800}

Patch Set 1 #

Patch Set 2 : Re-enable test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M mojo/public/js/connection.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Reilly Grant (use Gerrit)
Re-enable test.
4 years, 7 months ago (2016-05-10 23:04:47 UTC) #1
Reilly Grant (use Gerrit)
Please take a look.
4 years, 7 months ago (2016-05-10 23:05:09 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-10 23:16:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971603002/20001
4 years, 7 months ago (2016-05-10 23:18:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/188074)
4 years, 7 months ago (2016-05-11 00:27:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971603002/20001
4 years, 7 months ago (2016-05-11 00:31:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 01:04:47 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 01:07:43 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74030c0b688d538776300991ad778ae0b095a15e
Cr-Commit-Position: refs/heads/master@{#392800}

Powered by Google App Engine
This is Rietveld 408576698