Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1960413002: [ios] Replaced arrow function with regular function in connection.js. (Closed)

Created:
4 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Replaced arrow function with regular function in connection.js. Arrow functions are not supported by iOS's WKWebView which is used by Chrome for iOS. Arrow function was introduced in this CL: https://codereview.chromium.org/1951723002 Chrome for iOS will support mojo for WebUI hence will use connection.js BUG=None Committed: https://crrev.com/2d80afda606c4b4030d31ed7303059b56383efc6 Cr-Commit-Position: refs/heads/master@{#392517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/js/connection.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Eugene But (OOO till 7-30)
4 years, 7 months ago (2016-05-10 01:12:04 UTC) #2
Ken Rockot(use gerrit already)
This is unfortunate. LGTM
4 years, 7 months ago (2016-05-10 01:18:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960413002/1
4 years, 7 months ago (2016-05-10 01:29:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 02:17:10 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 02:18:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d80afda606c4b4030d31ed7303059b56383efc6
Cr-Commit-Position: refs/heads/master@{#392517}

Powered by Google App Engine
This is Rietveld 408576698