Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1971533005: Allow MediaRecorder to record Muted streams (Closed)

Created:
4 years, 7 months ago by emircan
Modified:
4 years, 7 months ago
Reviewers:
mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow MediaRecorder to record Muted streams This CL tries to address the bug by letting MediaRecorder to start recording even when the incoming stream is muted. BUG=611205 Committed: https://crrev.com/21a24223a6f5713de7b5cc162bade97c464ad8c4 Cr-Commit-Position: refs/heads/master@{#393093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M content/renderer/media/media_recorder_handler.cc View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
emircan
PTAL.
4 years, 7 months ago (2016-05-11 21:23:49 UTC) #3
mcasas
On 2016/05/11 21:23:49, emircan wrote: > PTAL. LGTM % bots being happy (might be this ...
4 years, 7 months ago (2016-05-11 21:34:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971533005/1
4 years, 7 months ago (2016-05-11 22:48:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 22:53:24 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 22:55:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21a24223a6f5713de7b5cc162bade97c464ad8c4
Cr-Commit-Position: refs/heads/master@{#393093}

Powered by Google App Engine
This is Rietveld 408576698