Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: content/renderer/media/media_recorder_handler.cc

Issue 1971533005: Allow MediaRecorder to record Muted streams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_recorder_handler.cc
diff --git a/content/renderer/media/media_recorder_handler.cc b/content/renderer/media/media_recorder_handler.cc
index 4bc45a0c9faa0524c134ee9b683beb57dec7f7d9..46dc73625fc727b5db039af94227cd5221201446 100644
--- a/content/renderer/media/media_recorder_handler.cc
+++ b/content/renderer/media/media_recorder_handler.cc
@@ -167,15 +167,15 @@ bool MediaRecorderHandler::start(int timeslice) {
return false;
}
- const bool use_video_tracks = !video_tracks.isEmpty() &&
- video_tracks[0].isEnabled() &&
- video_tracks[0].source().getReadyState() ==
- blink::WebMediaStreamSource::ReadyStateLive;
- const bool use_audio_tracks = !audio_tracks.isEmpty() &&
- MediaStreamAudioTrack::From(audio_tracks[0]) &&
- audio_tracks[0].isEnabled() &&
- audio_tracks[0].source().getReadyState() ==
- blink::WebMediaStreamSource::ReadyStateLive;
+ const bool use_video_tracks =
+ !video_tracks.isEmpty() && video_tracks[0].isEnabled() &&
+ video_tracks[0].source().getReadyState() !=
+ blink::WebMediaStreamSource::ReadyStateEnded;
+ const bool use_audio_tracks =
+ !audio_tracks.isEmpty() && MediaStreamAudioTrack::From(audio_tracks[0]) &&
+ audio_tracks[0].isEnabled() &&
+ audio_tracks[0].source().getReadyState() !=
+ blink::WebMediaStreamSource::ReadyStateEnded;
webm_muxer_.reset(new media::WebmMuxer(
CodecIdToMediaVideoCodec(codec_id_), use_video_tracks, use_audio_tracks,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698