Chromium Code Reviews| Index: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc |
| diff --git a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc |
| index e4d6fc7752ac763981c93f479161c380dda9598b..7a6200c3cc93e978d81bd253423961b6c1151afa 100644 |
| --- a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc |
| +++ b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc |
| @@ -257,35 +257,14 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, Visibility) { |
| EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0)); |
| // Shrink the browser actions bar to zero visible icons. |
| - // No icons should be visible, but we *should* show the chevron and have a |
| - // non-empty size. |
| toolbar_model()->SetVisibleIconCount(0); |
| EXPECT_EQ(0, browser_actions_bar()->VisibleBrowserActions()); |
| - EXPECT_TRUE(browser_actions_bar()->IsChevronShowing()); |
| - // Reset visibility count to 2. State should be A, B, [C], and the chevron |
| - // should be visible. |
| + // Reset visibility count to 2. State should be A, B, [C]. |
| toolbar_model()->SetVisibleIconCount(2); |
| EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions()); |
| EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0)); |
| EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); |
| - EXPECT_TRUE(browser_actions_bar()->IsChevronShowing()); |
| - |
| - // Disable C (the overflowed extension). State should now be A, B, and the |
| - // chevron should be hidden. |
| - DisableExtension(extension_c()->id()); |
| - EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions()); |
| - EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0)); |
| - EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); |
| - EXPECT_FALSE(browser_actions_bar()->IsChevronShowing()); |
|
Devlin
2016/05/11 00:01:02
Instead of removing these pieces, can you do:
Tool
Evan Stade
2016/05/11 21:05:35
yes
|
| - |
| - // Re-enable C. We should still only have 2 visible icons, and the chevron |
| - // should be visible. |
| - EnableExtension(extension_c()->id()); |
| - EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions()); |
| - EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0)); |
| - EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); |
| - EXPECT_TRUE(browser_actions_bar()->IsChevronShowing()); |
| } |
| // Test that, with the toolbar action redesign, actions that want to run have |