Get rid of some lingering MD-specific raster assets.

chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 239 matching lines @@
   EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions());
   EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(0));
 
   // Enable A. State becomes: A, B, C.
   EnableExtension(extension_a()->id());
   EXPECT_EQ(3, browser_actions_bar()->NumberOfBrowserActions());
   EXPECT_EQ(3, browser_actions_bar()->VisibleBrowserActions());
   EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0));
 
   // Shrink the browser actions bar to zero visible icons.
-  // No icons should be visible, but we *should* show the chevron and have a
-  // non-empty size.
   toolbar_model()->SetVisibleIconCount(0);
   EXPECT_EQ(0, browser_actions_bar()->VisibleBrowserActions());
-  EXPECT_TRUE(browser_actions_bar()->IsChevronShowing());
 
-  // Reset visibility count to 2. State should be A, B, [C], and the chevron
-  // should be visible.
+  // Reset visibility count to 2. State should be A, B, [C].
   toolbar_model()->SetVisibleIconCount(2);
   EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions());
   EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0));
   EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1));
-  EXPECT_TRUE(browser_actions_bar()->IsChevronShowing());
-
-  // Disable C (the overflowed extension). State should now be A, B, and the
-  // chevron should be hidden.
-  DisableExtension(extension_c()->id());
-  EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions());
-  EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0));
-  EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1));
-  EXPECT_FALSE(browser_actions_bar()->IsChevronShowing());

[Devlin, 2016/05/11 00:01:02]

Instead of removing these pieces, can you do:
ToolbarActionsBar* toolbar_actions_bar =
    browser_actions_bar()->GetToolbarActionsBar();
and replace instances of 
browser_actions_bar()->IsChevronShowing()
with
toolbar_actions_bar->NeedsOverflow()
?

Do the tests pass with that?

[Evan Stade, 2016/05/11 21:05:35]

yes

-
-  // Re-enable C. We should still only have 2 visible icons, and the chevron
-  // should be visible.
-  EnableExtension(extension_c()->id());
-  EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions());
-  EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0));
-  EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1));
-  EXPECT_TRUE(browser_actions_bar()->IsChevronShowing());
 }
 
 // Test that, with the toolbar action redesign, actions that want to run have
 // the proper appearance.
 IN_PROC_BROWSER_TEST_F(BrowserActionsBarRedesignBrowserTest,
                        TestUiForActionsWantToRun) {
   LoadExtensions();
   EXPECT_EQ(3, browser_actions_bar()->VisibleBrowserActions());
 
   // Load an extension with a page action.
@@ skipping 247 matching lines @@
   EXPECT_EQ(page_action_extension->id(),
             browser_actions_bar()->GetExtensionId(0));
   browser_actions_bar()->Press(0);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(browser_actions_bar()->HasPopup());
   // Cleanup the popup (to avoid having windows open at tear down).
   browser_actions_bar()->HidePopup();
   content::RunAllBlockingPoolTasksUntilIdle();
   EXPECT_FALSE(browser_actions_bar()->HasPopup());
 }