Fixes up dump_syms build on OS X so it works with ELF.

Fixes up dump_syms build on OS X so it works with ELF.

Adds elf.h header from glibc.
Updates dwarf2reader.cc so it isn't comparing a unique_ptr against NULL.
Moves from MacOS10.5 SDK to latest SDK for Xcode project.
Moves from using gcc to clang for dump_syms tests.
Disables warning about 'Missing Field In Structure Initializers' to temporarily work around https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697.

With this patch all tests form dump_syms pass again using Xcode 7.3 on Mac OS X 10.11.

BUG= https://bugs.chromium.org/p/google-breakpad/issues/detail?id=696, https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697
R=mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/3d225e288c95902b965e0a06333dfdbe25a637b5

[dmac, 2016-05-11 21:01:17]

Description was changed from

==========
Fixes up dump_syms build on OS X so it works with ELF.

Adds elf.h header from glibc.
Updates dwarf2reader.cc so it isn't comparing a unique_ptr against NULL.
Moves from MacOS10.5 SDK to latest SDK for Xcode project.
Moves from using gcc to clang for dump_syms tests.
Disables warning about 'Missing Field In Structure Initializers' to temporarily
work around https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697.

With this patch all tests form dump_syms pass again using Xcode 7.3 on Mac OS X
10.11.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=696,
https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697
==========

to

==========
Fixes up dump_syms build on OS X so it works with ELF.

Adds elf.h header from glibc.
Updates dwarf2reader.cc so it isn't comparing a unique_ptr against NULL.
Moves from MacOS10.5 SDK to latest SDK for Xcode project.
Moves from using gcc to clang for dump_syms tests.
Disables warning about 'Missing Field In Structure Initializers' to temporarily
work around https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697.

With this patch all tests form dump_syms pass again using Xcode 7.3 on Mac OS X
10.11.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=696,
https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697
==========

[dmac, 2016-05-11 21:01:17]

dmaclach@chromium.org changed reviewers:
+ ivanpe@chromium.org, mark@chromium.org

[dmac, 2016-05-11 21:01:33]

Description was changed from

==========
Fixes up dump_syms build on OS X so it works with ELF.

Adds elf.h header from glibc.
Updates dwarf2reader.cc so it isn't comparing a unique_ptr against NULL.
Moves from MacOS10.5 SDK to latest SDK for Xcode project.
Moves from using gcc to clang for dump_syms tests.
Disables warning about 'Missing Field In Structure Initializers' to temporarily
work around https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697.

With this patch all tests form dump_syms pass again using Xcode 7.3 on Mac OS X
10.11.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=696,
https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697
==========

to

==========
Fixes up dump_syms build on OS X so it works with ELF.

Adds elf.h header from glibc.
Updates dwarf2reader.cc so it isn't comparing a unique_ptr against NULL.
Moves from MacOS10.5 SDK to latest SDK for Xcode project.
Moves from using gcc to clang for dump_syms tests.
Disables warning about 'Missing Field In Structure Initializers' to temporarily
work around https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697.

With this patch all tests form dump_syms pass again using Xcode 7.3 on Mac OS X
10.11.

BUG= https://bugs.chromium.org/p/google-breakpad/issues/detail?id=696,
https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697
==========

[Mark Mentovai, 2016-05-12 18:29:53]

LGTM

[dmac, 2016-05-12 18:38:13]

Description was changed from

==========
Fixes up dump_syms build on OS X so it works with ELF.

Adds elf.h header from glibc.
Updates dwarf2reader.cc so it isn't comparing a unique_ptr against NULL.
Moves from MacOS10.5 SDK to latest SDK for Xcode project.
Moves from using gcc to clang for dump_syms tests.
Disables warning about 'Missing Field In Structure Initializers' to temporarily
work around https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697.

With this patch all tests form dump_syms pass again using Xcode 7.3 on Mac OS X
10.11.

BUG= https://bugs.chromium.org/p/google-breakpad/issues/detail?id=696,
https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697
==========

to

==========
Fixes up dump_syms build on OS X so it works with ELF.

Adds elf.h header from glibc.
Updates dwarf2reader.cc so it isn't comparing a unique_ptr against NULL.
Moves from MacOS10.5 SDK to latest SDK for Xcode project.
Moves from using gcc to clang for dump_syms tests.
Disables warning about 'Missing Field In Structure Initializers' to temporarily
work around https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697.

With this patch all tests form dump_syms pass again using Xcode 7.3 on Mac OS X
10.11.

BUG= https://bugs.chromium.org/p/google-breakpad/issues/detail?id=696,
https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/3d225e288c95902b965e0a0...
==========

[dmac, 2016-05-12 18:38:14]

Committed patchset #2 (id:20001) manually as
3d225e288c95902b965e0a06333dfdbe25a637b5 (presubmit successful).

[Ted Mielczarek, 2016-05-12 18:57:39]

https://codereview.chromium.org/1970903002/diff/20001/src/third_party/glibc/e...
File src/third_party/glibc/elf/elf.h (right):

https://codereview.chromium.org/1970903002/diff/20001/src/third_party/glibc/e...
src/third_party/glibc/elf/elf.h:17: <http://www.gnu.org/licenses/>.  */
Is putting LGPL code in the Breakpad repo really OK?

[Mark Mentovai, 2016-05-12 19:00:37]

This is just a code-less header describing data structures. I thought that was
OK. Dave, maybe you want to follow up with someone.

[vapier, 2016-05-12 19:04:55]

vapier@chromium.org changed reviewers:
+ vapier@chromium.org

[vapier, 2016-05-12 19:04:56]

it should be fine.  otherwise, you're saying anyone doing "#include <elf.h>" (or
just about any other header) on a glibc system is now under the LGPL.

[vapier, 2016-05-12 19:17:51]

we could use the one from musl instead -- that'll be under an MIT license:
https://git.musl-libc.org/cgit/musl/tree/include/elf.h
https://git.musl-libc.org/cgit/musl/tree/COPYRIGHT

it should be just as "full featured" as the glibc one.