Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1970903002: Fixes up dump_syms build on OS X so it works with ELF. (Closed)

Created:
4 years, 7 months ago by dmac
Modified:
4 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes up dump_syms build on OS X so it works with ELF. Adds elf.h header from glibc. Updates dwarf2reader.cc so it isn't comparing a unique_ptr against NULL. Moves from MacOS10.5 SDK to latest SDK for Xcode project. Moves from using gcc to clang for dump_syms tests. Disables warning about 'Missing Field In Structure Initializers' to temporarily work around https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697. With this patch all tests form dump_syms pass again using Xcode 7.3 on Mac OS X 10.11. BUG= https://bugs.chromium.org/p/google-breakpad/issues/detail?id=696, https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697 R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/3d225e288c95902b965e0a06333dfdbe25a637b5

Patch Set 1 #

Patch Set 2 : Change xcconfig instead of xcodeproj #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4500 lines, -13 lines) Patch
M src/common/dwarf/dwarf2reader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/common/mac/Breakpad.xcconfig View 1 3 chunks +4 lines, -8 lines 0 comments Download
A src/common/mac/include/features.h View 1 chunk +16 lines, -0 lines 0 comments Download
A src/third_party/glibc/COPYING View 1 chunk +339 lines, -0 lines 0 comments Download
A src/third_party/glibc/LICENSES View 1 chunk +469 lines, -0 lines 0 comments Download
A src/third_party/glibc/README View 1 chunk +76 lines, -0 lines 0 comments Download
A src/third_party/glibc/README.breakpad View 1 chunk +3 lines, -0 lines 0 comments Download
A src/third_party/glibc/elf/elf.h View 1 chunk +3572 lines, -0 lines 1 comment Download
M src/tools/mac/dump_syms/dump_syms.xcodeproj/project.pbxproj View 1 10 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Mark Mentovai
LGTM
4 years, 7 months ago (2016-05-12 18:29:53 UTC) #4
dmac
Committed patchset #2 (id:20001) manually as 3d225e288c95902b965e0a06333dfdbe25a637b5 (presubmit successful).
4 years, 7 months ago (2016-05-12 18:38:14 UTC) #6
Ted Mielczarek
https://codereview.chromium.org/1970903002/diff/20001/src/third_party/glibc/elf/elf.h File src/third_party/glibc/elf/elf.h (right): https://codereview.chromium.org/1970903002/diff/20001/src/third_party/glibc/elf/elf.h#newcode17 src/third_party/glibc/elf/elf.h:17: <http://www.gnu.org/licenses/>. */ Is putting LGPL code in the Breakpad ...
4 years, 7 months ago (2016-05-12 18:57:39 UTC) #7
Mark Mentovai
This is just a code-less header describing data structures. I thought that was OK. Dave, ...
4 years, 7 months ago (2016-05-12 19:00:37 UTC) #8
vapier
it should be fine. otherwise, you're saying anyone doing "#include <elf.h>" (or just about any ...
4 years, 7 months ago (2016-05-12 19:04:56 UTC) #10
vapier
4 years, 7 months ago (2016-05-12 19:17:51 UTC) #11
Message was sent while issue was closed.
we could use the one from musl instead -- that'll be under an MIT license:
https://git.musl-libc.org/cgit/musl/tree/include/elf.h
https://git.musl-libc.org/cgit/musl/tree/COPYRIGHT

it should be just as "full featured" as the glibc one.

Powered by Google App Engine
This is Rietveld 408576698