src/common/mac/Breakpad.xcconfig - Issue 1970903002: Fixes up dump_syms build on OS X so it works with ELF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/common/mac/Breakpad.xcconfig

Issue 1970903002: Fixes up dump_syms build on OS X so it works with ELF. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Change xcconfig instead of xcodeproj Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/common/mac/Breakpad.xcconfig

diff --git a/src/common/mac/Breakpad.xcconfig b/src/common/mac/Breakpad.xcconfig

index 672be2cee555fde4dcd2f928df3caba2d3f69c30..f09136908109ddaf082042b93e1893d13f13f9dd 100644

--- a/src/common/mac/Breakpad.xcconfig

+++ b/src/common/mac/Breakpad.xcconfig

@@ -27,12 +27,6 @@

// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-ARCHS = $(ARCHS_STANDARD_32_64_BIT)

-SDKROOT = macosx10.5

-GCC_VERSION = 4.2

-GCC_VERSION[sdk=macosx10.4][arch=*] = 4.0

GCC_C_LANGUAGE_STANDARD = c99

GCC_WARN_CHECK_SWITCH_STATEMENTS = YES

@@ -41,7 +35,10 @@ GCC_WARN_64_TO_32_BIT_CONVERSION = NO

GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES

GCC_WARN_ABOUT_RETURN_TYPE = YES

GCC_WARN_MISSING_PARENTHESES = YES

-GCC_WARN_ABOUT_MISSING_FIELD_INITIALIZERS = YES

+// Once https://bugs.chromium.org/p/google-breakpad/issues/detail?id=697

+// is fixed this should be reenabled.

+//GCC_WARN_ABOUT_MISSING_FIELD_INITIALIZERS = YES

GCC_WARN_ABOUT_MISSING_NEWLINE = YES

GCC_WARN_SIGN_COMPARE = YES

GCC_TREAT_IMPLICIT_FUNCTION_DECLARATIONS_AS_ERRORS = YES

@@ -51,6 +48,5 @@ GCC_WARN_UNUSED_VARIABLE = YES

GCC_TREAT_WARNINGS_AS_ERRORS = YES

DEBUG_INFORMATION_FORMAT = dwarf-with-dsym

-DEBUG_INFORMATION_FORMAT[sdk=macosx10.4][arch=*] = stabs

ALWAYS_SEARCH_USER_PATHS = NO

« no previous file with comments | « src/common/dwarf/dwarf2reader.cc ('k') | src/common/mac/include/features.h » ('j') | src/third_party/glibc/elf/elf.h » ('J')