Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 197083003: Temporarily disable direct NPAPI requests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by eustas
Modified:
3 years, 5 months ago
Reviewers:
jam, ananta, pfeldman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Temporarily disable direct NPAPI requests. Direct NPAPI requests are not tracked by DevTools. Lots of users complain that this affected their work and productivity. So, we should temporarily disable this feature. (Until new requests instrumentation is added) BUG=173844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)
eustas
3 years, 6 months ago (2014-03-25 13:34:24 UTC) #1
jam
On 2014/03/25 13:34:24, eustas wrote: not lgtm, i actually have a local change removing this ...
3 years, 6 months ago (2014-03-25 15:04:25 UTC) #2
LiamKarlMitchell
3 years, 5 months ago (2014-05-12 00:27:48 UTC) #3
Message was sent while issue was closed.
On 2014/03/25 15:04:25, jam wrote:
> On 2014/03/25 13:34:24, eustas wrote:
> 
> not lgtm, i actually have a local change removing this old path.
> 
> I thought I had commented on one of the bugs about this, or maybe it was about
> these requests not showing through the extensions apis. in both cases, it's
> first important to note that this is only for NPAPI plugins. Most users use
> pepper flash, and that is the only supported flash in chrome now. for
> silverlight and other plugins (which have drastically lower usage rates), it's
> ok if features like devtools don't work (while devtools might be very
important
> for web development, having it work with npapi requests is not so important).
we
> are going to remove npapi completely on linux in m35 and on win/mac before the
> end of the year.

Will we be able to use Dev Tools once NPAPI is removed to see network requests
from these NPAPI plugins? (Adobe flash debug player, silverlight etc)

Maybe this setting should be added to the chrome://flags so developers can still
use the Dev Tools on flash and other plugins?.
Or will these plugins stop working in chrome?

I have to use flash at my work for supporting existing products and not being
able to use the Debug player would make things rather difficult....
Why remove something if it is working?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa