Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1970813002: Refactor sample to share boiler plate code. (Closed)

Created:
4 years, 7 months ago by herb_g
Modified:
4 years, 7 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Refactor sample to share boiler plate code. TODO: move to common calls from SkPM4f. This preparation to finish handling the rest of the SkColorTypes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1970813002 Committed: https://skia.googlesource.com/skia/+/dd964893908c1f91b3ca928a157fef99effd6f49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -143 lines) Patch
M src/core/SkLinearBitmapPipeline_sample.h View 16 chunks +129 lines, -143 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
herb_g
4 years, 7 months ago (2016-05-11 15:45:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970813002/1
4 years, 7 months ago (2016-05-11 16:17:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 16:40:56 UTC) #8
f(malita)
lgtm
4 years, 7 months ago (2016-05-11 16:58:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970813002/1
4 years, 7 months ago (2016-05-11 17:39:04 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 17:39:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd964893908c1f91b3ca928a157fef99effd6f49

Powered by Google App Engine
This is Rietveld 408576698