Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1967793003:
Use common code from SkPM4fPriv (Closed)
DescriptionUse common code from SkPM4fPriv
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1967793003
Committed: https://skia.googlesource.com/skia/+/cf05dcd64b47dcf5e6ff02132d2b57d3b40d0bf1
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address Florin's comments. #Messages
Total messages: 20 (10 generated)
Description was changed from ========== Use common code from SkPM4fPriv BUG=skia: ========== to ========== Use common code from SkPM4fPriv BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Use common code from SkPM4fPriv BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Use common code from SkPM4fPriv BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
herb@google.com changed reviewers: + fmalita@chromium.org
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967793003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1967793003/diff/1/src/core/SkLinearBitmapPipe... File src/core/SkLinearBitmapPipeline_sample.h (right): https://codereview.chromium.org/1967793003/diff/1/src/core/SkLinearBitmapPipe... src/core/SkLinearBitmapPipeline_sample.h:626: pixel = pixel * (1.0f/255.0f); Nit: these two lines are equivalent to Sk4f_fromL32(). I think we could re-write this method as return colorProfile == kSRGB_SkColorProfileType ? Sk4f_fromS32(*src) : Sk4f_fromL32(*src); https://codereview.chromium.org/1967793003/diff/1/src/core/SkLinearBitmapPipe... src/core/SkLinearBitmapPipeline_sample.h:661: } Nit: maybe also rewrite as Sk4f pixel = colorProfile == kSRGB_SkColorProfileType ? Sk4f_fromS32(*src) : Sk4f_fromL32(*src); return SkNx_shuffle<2, 1, 0, 3>(pixel); ?
Address Florin's comments.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967793003/20001
https://codereview.chromium.org/1967793003/diff/1/src/core/SkLinearBitmapPipe... File src/core/SkLinearBitmapPipeline_sample.h (right): https://codereview.chromium.org/1967793003/diff/1/src/core/SkLinearBitmapPipe... src/core/SkLinearBitmapPipeline_sample.h:626: pixel = pixel * (1.0f/255.0f); On 2016/05/11 16:54:03, f(malita) wrote: > Nit: these two lines are equivalent to Sk4f_fromL32(). I think we could > re-write this method as > > return colorProfile == kSRGB_SkColorProfileType > ? Sk4f_fromS32(*src) > : Sk4f_fromL32(*src); Done. https://codereview.chromium.org/1967793003/diff/1/src/core/SkLinearBitmapPipe... src/core/SkLinearBitmapPipeline_sample.h:661: } On 2016/05/11 16:54:03, f(malita) wrote: > Nit: maybe also rewrite as > > Sk4f pixel = colorProfile == kSRGB_SkColorProfileType > ? Sk4f_fromS32(*src) > : Sk4f_fromL32(*src); > return SkNx_shuffle<2, 1, 0, 3>(pixel); > > ? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by herb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/1967793003/#ps20001 (title: "Address Florin's comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967793003/20001
Message was sent while issue was closed.
Description was changed from ========== Use common code from SkPM4fPriv BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Use common code from SkPM4fPriv BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/cf05dcd64b47dcf5e6ff02132d2b57d3b40d0bf1 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/cf05dcd64b47dcf5e6ff02132d2b57d3b40d0bf1 |
