third_party/WebKit/Source/core/frame/FrameHost.h - Issue 1970763002: Fixed up root scroller API to be more webby

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameHost.h

Issue 1970763002: Fixed up root scroller API to be more webby (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sigh...fix test expectation again, fix crash when there's no renderer Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameHost.h

diff --git a/third_party/WebKit/Source/core/frame/FrameHost.h b/third_party/WebKit/Source/core/frame/FrameHost.h

index 247e50055d49e75985f80b322907d7b9e426d773..b3685b9767b333ad181451b233531237e07449e9 100644

--- a/third_party/WebKit/Source/core/frame/FrameHost.h

+++ b/third_party/WebKit/Source/core/frame/FrameHost.h

@@ -50,7 +50,6 @@ class OverscrollController;

class Page;

struct PageScaleConstraints;

class PageScaleConstraintsSet;

-class RootScroller;

class Settings;

class TopControls;

class UseCounter;

@@ -98,9 +97,6 @@ public:

// use ChromeClient::screenInfo() instead.

float deviceScaleFactorDeprecated() const;

- RootScroller* rootScroller();

- const RootScroller* rootScroller() const;

TopControls& topControls();

const TopControls& topControls() const;

@@ -143,7 +139,6 @@ private:

explicit FrameHost(Page&);

const Member<Page> m_page;

- const Member<RootScroller> m_rootScroller;

const Member<TopControls> m_topControls;

const OwnPtr<PageScaleConstraintsSet> m_pageScaleConstraintsSet;

const Member<VisualViewport> m_visualViewport;