Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/core/frame/FrameHost.cpp

Issue 1970763002: Fixed up root scroller API to be more webby (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sigh...fix test expectation again, fix crash when there's no renderer Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameHost.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameHost.cpp b/third_party/WebKit/Source/core/frame/FrameHost.cpp
index f7093702c17f5d970399765a247995afe89c8dc5..93ca639606ece06f40c3ae765f86ddad26eadf89 100644
--- a/third_party/WebKit/Source/core/frame/FrameHost.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameHost.cpp
@@ -40,7 +40,6 @@
#include "core/inspector/ConsoleMessageStorage.h"
#include "core/page/Page.h"
#include "core/page/scrolling/OverscrollController.h"
-#include "core/page/scrolling/RootScroller.h"
#include "public/platform/Platform.h"
#include "public/platform/WebScheduler.h"
@@ -53,7 +52,6 @@ FrameHost* FrameHost::create(Page& page)
FrameHost::FrameHost(Page& page)
: m_page(&page)
- , m_rootScroller(RootScroller::create(*this))
, m_topControls(TopControls::create(*this))
, m_pageScaleConstraintsSet(PageScaleConstraintsSet::create())
, m_visualViewport(VisualViewport::create(*this))
@@ -127,26 +125,6 @@ float FrameHost::deviceScaleFactorDeprecated() const
return m_page->deviceScaleFactor();
}
-RootScroller* FrameHost::rootScroller()
-{
- // RootScroller only makes sense if we're in the process where the main
- // frame is local.
- if (!m_page->mainFrame() || !m_page->mainFrame()->isLocalFrame())
- return nullptr;
-
- return m_rootScroller;
-}
-
-const RootScroller* FrameHost::rootScroller() const
-{
- // RootScroller only makes sense if we're in the process where the main
- // frame is local.
- if (!m_page->mainFrame() || !m_page->mainFrame()->isLocalFrame())
- return nullptr;
-
- return m_rootScroller;
-}
-
TopControls& FrameHost::topControls()
{
return *m_topControls;
@@ -220,7 +198,6 @@ const CustomElementReactionStack& FrameHost::customElementReactionStack() const
DEFINE_TRACE(FrameHost)
{
visitor->trace(m_page);
- visitor->trace(m_rootScroller);
visitor->trace(m_topControls);
visitor->trace(m_visualViewport);
visitor->trace(m_overscrollController);
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698