Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1970743002: Switch GrTextureToYUVPlanes over to newDrawContext calls (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change newDrawContext contract #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -75 lines) Patch
M include/gpu/GrContext.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrTextureToYUVPlanes.cpp View 1 4 chunks +57 lines, -75 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
robertphillips
4 years, 7 months ago (2016-05-11 13:23:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970743002/1
4 years, 7 months ago (2016-05-11 13:23:44 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 13:47:40 UTC) #8
bsalomon
https://codereview.chromium.org/1970743002/diff/1/src/gpu/GrTextureToYUVPlanes.cpp File src/gpu/GrTextureToYUVPlanes.cpp (right): https://codereview.chromium.org/1970743002/diff/1/src/gpu/GrTextureToYUVPlanes.cpp#newcode144 src/gpu/GrTextureToYUVPlanes.cpp:144: if (!yuvTex) { could this be an assert? Can ...
4 years, 7 months ago (2016-05-11 14:29:52 UTC) #9
robertphillips
https://codereview.chromium.org/1970743002/diff/1/src/gpu/GrTextureToYUVPlanes.cpp File src/gpu/GrTextureToYUVPlanes.cpp (right): https://codereview.chromium.org/1970743002/diff/1/src/gpu/GrTextureToYUVPlanes.cpp#newcode144 src/gpu/GrTextureToYUVPlanes.cpp:144: if (!yuvTex) { On 2016/05/11 14:29:52, bsalomon wrote: > ...
4 years, 7 months ago (2016-05-11 15:06:03 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970743002/20001
4 years, 7 months ago (2016-05-11 15:06:21 UTC) #12
bsalomon
lgtm
4 years, 7 months ago (2016-05-11 15:17:16 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 15:32:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970743002/20001
4 years, 7 months ago (2016-05-11 15:33:45 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 15:34:42 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ebf30e84156358d6841305ecea21c7c979370bad

Powered by Google App Engine
This is Rietveld 408576698