Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19706002: Remove plugin_list.h includes from chrome tests in preparation for moving webkit/plugins to content… (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Remove plugin_list.h includes from chrome tests in preparation for moving webkit/plugins to content/. To do this, I simplified how we disable plugin loading for tests, and also updated the test in content to use the new way. BUG=237249 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212249

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add comments to PluginService methods since PluginList will be an internal implementation detail #

Total comments: 3

Patch Set 4 : sync #

Total comments: 2

Patch Set 5 : fix posix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -245 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 2 3 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 1 2 3 3 chunks +4 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 2 3 3 chunks +20 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_apitest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 4 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_unittest.cc View 1 2 3 4 5 chunks +31 lines, -8 lines 0 comments Download
M chrome/browser/printing/print_preview_test.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_preview_test.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc View 1 2 3 4 5 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_service_impl.h View 1 2 3 2 chunks +3 lines, -7 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 2 3 11 chunks +32 lines, -34 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/plugin_service.h View 1 2 3 2 chunks +23 lines, -12 lines 0 comments Download
D webkit/plugins/npapi/mock_plugin_list.h View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/plugins/npapi/mock_plugin_list.cc View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.h View 1 2 3 4 chunks +3 lines, -8 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_unittest.cc View 1 2 3 4 5 chunks +12 lines, -8 lines 0 comments Download
M webkit/plugins/webkit_plugins.gyp View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
7 years, 5 months ago (2013-07-17 23:50:36 UTC) #1
scottmg
https://codereview.chromium.org/19706002/diff/19004/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc File chrome/browser/extensions/api/content_settings/content_settings_apitest.cc (left): https://codereview.chromium.org/19706002/diff/19004/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc#oldcode101 chrome/browser/extensions/api/content_settings/content_settings_apitest.cc:101: switches::kEnableExperimentalExtensionApis); ? https://codereview.chromium.org/19706002/diff/30002/chrome/browser/plugins/plugin_prefs_unittest.cc File chrome/browser/plugins/plugin_prefs_unittest.cc (right): https://codereview.chromium.org/19706002/diff/30002/chrome/browser/plugins/plugin_prefs_unittest.cc#newcode216 chrome/browser/plugins/plugin_prefs_unittest.cc:216: scoped_refptr<content::MessageLoopRunner> ...
7 years, 5 months ago (2013-07-18 00:33:09 UTC) #2
jam
https://codereview.chromium.org/19706002/diff/19004/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc File chrome/browser/extensions/api/content_settings/content_settings_apitest.cc (left): https://codereview.chromium.org/19706002/diff/19004/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc#oldcode101 chrome/browser/extensions/api/content_settings/content_settings_apitest.cc:101: switches::kEnableExperimentalExtensionApis); On 2013/07/18 00:33:09, scottmg wrote: > ? i'm ...
7 years, 5 months ago (2013-07-18 00:36:34 UTC) #3
scottmg
7 years, 5 months ago (2013-07-18 00:38:29 UTC) #4 
lgtm

https://codereview.chromium.org/19706002/diff/19004/chrome/browser/extensions...
File chrome/browser/extensions/api/content_settings/content_settings_apitest.cc
(left):

https://codereview.chromium.org/19706002/diff/19004/chrome/browser/extensions...
chrome/browser/extensions/api/content_settings/content_settings_apitest.cc:101:
switches::kEnableExperimentalExtensionApis);
On 2013/07/18 00:36:34, jam wrote:
> On 2013/07/18 00:33:09, scottmg wrote:
> > ?
> 
> i'm not sure what you mean? that line moved up to line 103. i could have made
it
> stay here, but since i needed to change the command line early for
> kDisablePluginsDiscovery, i made both command line changes in the same method

sorry, missed that.

Powered by Google App Engine
This is Rietveld 408576698