Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5468)

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_apitest.cc

Issue 19706002: Remove plugin_list.h includes from chrome tests in preparation for moving webkit/plugins to content… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix posix tests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/content_settings/content_settings_apitest.cc
===================================================================
--- chrome/browser/extensions/api/content_settings/content_settings_apitest.cc (revision 212185)
+++ chrome/browser/extensions/api/content_settings/content_settings_apitest.cc (working copy)
@@ -12,7 +12,8 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
-#include "webkit/plugins/npapi/mock_plugin_list.h"
+#include "content/public/browser/plugin_service.h"
+#include "webkit/plugins/webplugininfo.h"
namespace extensions {
@@ -94,12 +95,18 @@
url, url, CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string()));
}
-// Flaky on the trybots. See http://crbug.com/96725.
-IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
- DISABLED_ContentSettingsGetResourceIdentifiers) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
+class ContentSettingsGetResourceIdentifiersTest : public ExtensionApiTest {
+ public:
+ virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
+ ExtensionApiTest::SetUpCommandLine(command_line);
+ command_line->AppendSwitch(switches::kDisablePluginsDiscovery);
+ command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);
+ }
+};
+// Flaky on the trybots. See http://crbug.com/96725.
+IN_PROC_BROWSER_TEST_F(ContentSettingsGetResourceIdentifiersTest,
+ DISABLED_Test) {
base::FilePath::CharType kFooPath[] =
FILE_PATH_LITERAL("/plugins/foo.plugin");
base::FilePath::CharType kBarPath[] =
@@ -107,29 +114,21 @@
const char* kFooName = "Foo Plugin";
const char* kBarName = "Bar Plugin";
- webkit::npapi::MockPluginList plugin_list;
- plugin_list.AddPluginToLoad(
+ content::PluginService::GetInstance()->RegisterInternalPlugin(
webkit::WebPluginInfo(ASCIIToUTF16(kFooName),
base::FilePath(kFooPath),
ASCIIToUTF16("1.2.3"),
- ASCIIToUTF16("foo")));
- plugin_list.AddPluginToLoad(
- webkit::WebPluginInfo(ASCIIToUTF16(kBarName),
+ ASCIIToUTF16("foo")),
+ false);
+ content::PluginService::GetInstance()->RegisterInternalPlugin(
+ webkit::WebPluginInfo(ASCIIToUTF16(kBarName),
base::FilePath(kBarPath),
ASCIIToUTF16("2.3.4"),
- ASCIIToUTF16("bar")));
+ ASCIIToUTF16("bar")),
+ false);
- std::vector<webkit::WebPluginInfo> plugins;
- plugin_list.GetPlugins(&plugins);
-
- ContentSettingsContentSettingGetResourceIdentifiersFunction::
- SetPluginsForTesting(&plugins);
-
EXPECT_TRUE(RunExtensionTest("content_settings/getresourceidentifiers"))
<< message_;
-
- ContentSettingsContentSettingGetResourceIdentifiersFunction::
- SetPluginsForTesting(NULL);
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698