Issue 1970593002: [Extensions] Check is_valid() in app bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1970593002: [Extensions] Check is_valid() in app bindings (Closed)

Created:
4 years, 7 months ago by Devlin

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[Extensions] Check is_valid() in app bindings The AppBindings object can potentially receive an IPC message after it's been invalided. Check before entering the v8 context. BUG=610224 Review-Url: https://codereview.chromium.org/1960173002 Cr-Commit-Position: refs/heads/master@{#392367} (cherry picked from commit c1872b891a46dda7bd25463374cbd305d343ecfc) Committed: https://chromium.googlesource.com/chromium/src/+/2264cb9287ce50bfea812e80325debcb1474e4d2

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/renderer/extensions/app_bindings.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Devlin

4 years, 7 months ago (2016-05-10 23:47:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2264cb9287ce50bfea812e80325debcb1474e4d2.