Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1960173002: [Extensions] Check is_valid() in app bindings (Closed)

Created:
4 years, 7 months ago by Devlin
Modified:
4 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Check is_valid() in app bindings The AppBindings object can potentially receive an IPC message after it's been invalided. Check before entering the v8 context. BUG=610224 Committed: https://crrev.com/c1872b891a46dda7bd25463374cbd305d343ecfc Cr-Commit-Position: refs/heads/master@{#392367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/renderer/extensions/app_bindings.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
4 years, 7 months ago (2016-05-09 16:34:56 UTC) #2
lazyboy
lgtm
4 years, 7 months ago (2016-05-09 18:08:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960173002/1
4 years, 7 months ago (2016-05-09 18:11:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 18:22:58 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 18:24:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1872b891a46dda7bd25463374cbd305d343ecfc
Cr-Commit-Position: refs/heads/master@{#392367}

Powered by Google App Engine
This is Rietveld 408576698