Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: src/frames.h

Issue 1970503004: [wasm] Differentiate unnamed and empty names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@add-utf8-check
Patch Set: Return null instead of undefined, and other cleanup Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/frames.cc » ('j') | src/frames.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index 4163d6f82e379dd3efe256c23d4a378f110fbe78..b66b9fdc52b16474c4c2411cb78780845c92f7e4 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -971,7 +971,9 @@ class WasmFrame : public StandardFrame {
Object* wasm_obj();
uint32_t function_index();
- Object* function_name();
+ // The function name, or nullptr if the function is unnamed, the name is not a
+ // valid UTF-8 string, or no wasm_obj is available (in testing).
+ String* function_name();
static WasmFrame* cast(StackFrame* frame) {
DCHECK(frame->is_wasm());
« no previous file with comments | « no previous file | src/frames.cc » ('j') | src/frames.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698