Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: src/frames.h

Issue 1970503004: [wasm] Differentiate unnamed and empty names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@add-utf8-check
Patch Set: Return null instead of undefined, and other cleanup Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/frames.cc » ('j') | src/frames.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FRAMES_H_ 5 #ifndef V8_FRAMES_H_
6 #define V8_FRAMES_H_ 6 #define V8_FRAMES_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/handles.h" 9 #include "src/handles.h"
10 #include "src/safepoint-table.h" 10 #include "src/safepoint-table.h"
(...skipping 953 matching lines...) Expand 10 before | Expand all | Expand 10 after
964 // Printing support. 964 // Printing support.
965 void Print(StringStream* accumulator, PrintMode mode, 965 void Print(StringStream* accumulator, PrintMode mode,
966 int index) const override; 966 int index) const override;
967 967
968 // Determine the code for the frame. 968 // Determine the code for the frame.
969 Code* unchecked_code() const override; 969 Code* unchecked_code() const override;
970 970
971 Object* wasm_obj(); 971 Object* wasm_obj();
972 uint32_t function_index(); 972 uint32_t function_index();
973 973
974 Object* function_name(); 974 // The function name, or nullptr if the function is unnamed, the name is not a
975 // valid UTF-8 string, or no wasm_obj is available (in testing).
976 String* function_name();
975 977
976 static WasmFrame* cast(StackFrame* frame) { 978 static WasmFrame* cast(StackFrame* frame) {
977 DCHECK(frame->is_wasm()); 979 DCHECK(frame->is_wasm());
978 return static_cast<WasmFrame*>(frame); 980 return static_cast<WasmFrame*>(frame);
979 } 981 }
980 982
981 protected: 983 protected:
982 inline explicit WasmFrame(StackFrameIteratorBase* iterator); 984 inline explicit WasmFrame(StackFrameIteratorBase* iterator);
983 985
984 Address GetCallerStackPointer() const override; 986 Address GetCallerStackPointer() const override;
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
1220 1222
1221 1223
1222 // Reads all frames on the current stack and copies them into the current 1224 // Reads all frames on the current stack and copies them into the current
1223 // zone memory. 1225 // zone memory.
1224 Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone); 1226 Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone);
1225 1227
1226 } // namespace internal 1228 } // namespace internal
1227 } // namespace v8 1229 } // namespace v8
1228 1230
1229 #endif // V8_FRAMES_H_ 1231 #endif // V8_FRAMES_H_
OLDNEW
« no previous file with comments | « no previous file | src/frames.cc » ('j') | src/frames.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698