Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: src/js/messages.js

Issue 1970503004: [wasm] Differentiate unnamed and empty names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@add-utf8-check
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime/runtime-function.cc » ('j') | src/wasm/wasm-function-name-table.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/messages.js
diff --git a/src/js/messages.js b/src/js/messages.js
index 2ff2dd052baaad0256d9a71d6a82c0d811548a66..28e7e426cb9c192d0328d366bfbed0a1237eae3f 100644
--- a/src/js/messages.js
+++ b/src/js/messages.js
@@ -633,7 +633,6 @@ function CallSiteGetFunctionName() {
if (HAS_PRIVATE(this, callSiteWasmObjectSymbol)) {
var wasm = GET_PRIVATE(this, callSiteWasmObjectSymbol);
var func_index = GET_PRIVATE(this, callSiteWasmFunctionIndexSymbol);
- if (IS_UNDEFINED(wasm)) return "<WASM>";
return %WasmGetFunctionName(wasm, func_index);
}
return %CallSiteGetFunctionNameRT(this);
@@ -679,6 +678,8 @@ function CallSiteToString() {
var funName = this.getFunctionName();
var funcIndex = GET_PRIVATE(this, callSiteWasmFunctionIndexSymbol);
var pos = this.getPosition();
+ if (IS_NULL_OR_UNDEFINED(funName))
+ funName = "<WASM UNNAMED>";
titzer 2016/05/12 09:05:51 Should probably also add the position here.
Clemens Hammacher 2016/05/12 09:45:57 It's still added in the line below, there is no re
titzer 2016/05/12 09:54:35 Acknowledged.
return funName + " (<WASM>:" + funcIndex + ":" + pos + ")";
titzer 2016/05/12 09:05:51 bikeshed: for this line: " (<WASM>[" + funcIndex
Clemens Hammacher 2016/05/12 09:45:57 Would you prefer this format for all wasm frames?
titzer 2016/05/12 09:54:35 yes
}
« no previous file with comments | « no previous file | src/runtime/runtime-function.cc » ('j') | src/wasm/wasm-function-name-table.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698