Convert track-webvtt-tc[003-005] tests to testharness.js

Convert track-webvtt-tc[003-005] tests to testharness.js

Cleaning up track-webvtt-tc[003-005] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/131ff1102b327aa48ee396356cb0ae45b8f63224
Cr-Commit-Position: refs/heads/master@{#395536}

[Srirama, 2016-05-19 18:53:34]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert track-webvtt-tc[003-005] tests to testharness.js 

Cleaning up track-webvtt-tc[003-005] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-05-19 18:53:52]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-05-19 18:54:15]

srirama.m@samsung.com changed reviewers:
+ mlamouri@chromium.org

[Srirama, 2016-05-19 18:54:16]

PTAL

[mlamouri (slow - plz ping), 2016-05-20 12:42:42]

https://codereview.chromium.org/1970483002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-webvtt-tc003-newlines.html
(right):

https://codereview.chromium.org/1970483002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-webvtt-tc003-newlines.html:25:
assert_cues_equal(cues, expected);
I think you can change assert_cues_equal() to check if `cues` and `expected` are
the same length which should allow you to simplify this check (and likely
others) because you don't need to check for the length before.

https://codereview.chromium.org/1970483002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/track/track-webvtt-tc004-magic-header.html
(right):

https://codereview.chromium.org/1970483002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-webvtt-tc004-magic-header.html:56:
assert_equals(video.textTracks[index].cues.length, 0);
That could probably be tested with:
```
assert_cues_equal(video.textTracks[index].cues, []);
```

[Srirama, 2016-05-20 13:26:30]

Patchset #2 (id:40001) has been deleted

[Srirama, 2016-05-20 13:32:38]

https://codereview.chromium.org/1970483002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-webvtt-tc003-newlines.html
(right):

https://codereview.chromium.org/1970483002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-webvtt-tc003-newlines.html:25:
assert_cues_equal(cues, expected);
On 2016/05/20 12:42:42, Mounir Lamouri wrote:
> I think you can change assert_cues_equal() to check if `cues` and `expected`
are
> the same length which should allow you to simplify this check (and likely
> others) because you don't need to check for the length before.

Done.

https://codereview.chromium.org/1970483002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/track/track-webvtt-tc004-magic-header.html
(right):

https://codereview.chromium.org/1970483002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-webvtt-tc004-magic-header.html:56:
assert_equals(video.textTracks[index].cues.length, 0);
On 2016/05/20 12:42:42, Mounir Lamouri wrote:
> That could probably be tested with:
> ```
> assert_cues_equal(video.textTracks[index].cues, []);
> ```

Done.

[mlamouri (slow - plz ping), 2016-05-23 23:16:59]

lgtm

[Srirama, 2016-05-24 03:16:23]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-05-24 03:16:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970483002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970483002/60001

[commit-bot: I haz the power, 2016-05-24 07:00:31]

Description was changed from

==========
Convert track-webvtt-tc[003-005] tests to testharness.js 

Cleaning up track-webvtt-tc[003-005] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert track-webvtt-tc[003-005] tests to testharness.js 

Cleaning up track-webvtt-tc[003-005] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-05-24 07:00:32]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-24 07:01:51]

Description was changed from

==========
Convert track-webvtt-tc[003-005] tests to testharness.js 

Cleaning up track-webvtt-tc[003-005] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert track-webvtt-tc[003-005] tests to testharness.js

Cleaning up track-webvtt-tc[003-005] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/131ff1102b327aa48ee396356cb0ae45b8f63224
Cr-Commit-Position: refs/heads/master@{#395536}
==========

[commit-bot: I haz the power, 2016-05-24 07:01:52]

Patchset 2 (id:??) landed as
https://crrev.com/131ff1102b327aa48ee396356cb0ae45b8f63224
Cr-Commit-Position: refs/heads/master@{#395536}