third_party/WebKit/LayoutTests/media/track/track-webvtt-tc003-newlines.html - Issue 1970483002: Convert track-webvtt-tc[003-005] tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc003-newlines.html

Issue 1970483002: Convert track-webvtt-tc[003-005] tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc003-newlines-expected.txt » ('j') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc004-magic-header.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>Tests that a cue with no newline at eof is properly parsed.</title>

3 <head>	3 <script src="track-helpers.js"></script>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <video>

	7 <track src="captions-webvtt/tc003-no-newline-at-eof.vtt" default>

	8 </video>

	9 <script>

	10 async_test(function(t) {

	11 var track = document.querySelector("track");

5	12

6 <script src=../media-file.js></script>	13 track.onload = t.step_func_done(function() {

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	14 var expected = [

8 (Please avoid writing new tests using video-test.js) -->	15 {

9 <script src=../video-test.js></script>	16 id : "1",

10 <script>	17 startTime : 0,

	18 endTime : 30.5,

	19 text : "Bear is Coming!!!!!"

	20 }

	21 ];

11	22

12 function trackLoaded()	23 var cues = track.track.cues;

13 {	24 assert_equals(cues.length, 1);

14 findMediaElement();	25 assert_cues_equal(cues, expected);
	mlamouri (slow - plz ping) 2016/05/20 12:42:42 I think you can change assert_cues_equal() to chec I think you can change assert_cues_equal() to check if `cues` and `expected` are the same length which should allow you to simplify this check (and likely others) because you don't need to check for the length before. Srirama 2016/05/20 13:32:38 Done. Show quoted text On 2016/05/20 12:42:42, Mounir Lamouri wrote: > I think you can change assert_cues_equal() to check if `cues` and `expected` are > the same length which should allow you to simplify this check (and likely > others) because you don't need to check for the length before. Done.
15 var expected =	26 });

16 {	27 });

17 length : 1,	28 </script>

18 tests:

19 [

20 {

21 property : "id",

22 values : [1],

23 },

24 {

25 property : "startTime",

26 values : [0.0],

27 },

28 {

29 property : "endTime",

30 values : [30.5],

31 },

32 {

33 property : "text",

34 values : ["Bear is Coming!!!!!"],

35 },

36 ],

37 };

38 testCues(0, expected);

39

40 endTest();

41 }

42 </script>

43 </head>

44 <body>

45 <p>Tests that a cue with no newline at eof is properly parsed.</p>

46 <video>

47 <track src="captions-webvtt/tc003-no-newline-at-eof.vtt" onload="tra ckLoaded()" default>

48 </video>

49 </body>

50 </html>

OLD	NEW