Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1970333004: Revert of add UseCounters for NonOctalDecimalIntegerLiteral in strict mode (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of add UseCounters for NonOctalDecimalIntegerLiteral in strict mode (patchset #6 id:100001 of https://codereview.chromium.org/1948403002/ ) Reason for revert: [Sheriff] Breaks https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/602 Original issue's description: > In parallel to the strict octal check that would reject `012` in strict mode, this patch collects UseCounters for `089` in strict mode. The spec says this should be an error, but this patch does not report it as such. > > BUG=v8:4973 > LOG=y > > Committed: https://crrev.com/d0b6686c14339bd5d0aeaf610705c7ed85393e1f > Cr-Commit-Position: refs/heads/master@{#36221} TBR=littledan@chromium.org,caitpotter88@gmail.com,jwolfe@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4973 Committed: https://crrev.com/a05ecb05b68e591f0d729a6eb1b6616f422edb44 Cr-Commit-Position: refs/heads/master@{#36224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -55 lines) Patch
M include/v8.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/parsing/scanner.h View 2 chunks +2 lines, -9 lines 0 comments Download
M src/parsing/scanner.cc View 8 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of add UseCounters for NonOctalDecimalIntegerLiteral in strict mode
4 years, 7 months ago (2016-05-13 06:52:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970333004/1
4 years, 7 months ago (2016-05-13 06:52:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 06:53:00 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 06:54:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a05ecb05b68e591f0d729a6eb1b6616f422edb44
Cr-Commit-Position: refs/heads/master@{#36224}

Powered by Google App Engine
This is Rietveld 408576698