Audio notification plumbed from guest WebContents up to embedder.

Audio notification plumbed from guest WebContents up to embedder.

When a guest webcontents is playing audio, there is no way for an
entity interacting with the embedder webcontents to determine this.
This CL adds two things:
i) The ability for WebContentsImpl::WasRecentlyAudible() to query any
guest/child contents to determine if they were recently audible, and
ii) the ability for a guest webcontents to pass any navigation state
changes up to the embedder in order to make them visible at the top
level.

BUG=590656
Committed: https://crrev.com/1dabf3e34c14d34d9fb262a54cd26c1878eb0034
Cr-Commit-Position: refs/heads/master@{#393689}

[wjmaclean, 2016-05-12 17:51:28]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 17:51:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970313002/1

[commit-bot: I haz the power, 2016-05-12 19:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 19:48:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[wjmaclean, 2016-05-13 20:08:03]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 20:08:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970313002/20001

[wjmaclean, 2016-05-13 20:10:56]

Patchset #2 (id:20001) has been deleted

[wjmaclean, 2016-05-13 20:11:03]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 20:11:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970313002/40001

[wjmaclean, 2016-05-13 20:12:10]

Description was changed from

==========
Audio notification plumbed from guest WebContents up to embedder.

When a guest webcontents is playing audio, there is no way for an
entity interacting with the embedder webcontents to determine this.
This CL adds two things:
i) The ability for WebContentsImpl::WasRecentlyAudible() to query any
guest/child contents to determine if they were recently audible, and
ii) the ability for a guest webcontents to pass any navigation state
changes up to the embedder in order to make them visible at the top
level.

BUG=590656
==========

to

==========
Audio notification plumbed from guest WebContents up to embedder.

When a guest webcontents is playing audio, there is no way for an
entity interacting with the embedder webcontents to determine this.
This CL adds two things:
i) The ability for WebContentsImpl::WasRecentlyAudible() to query any
guest/child contents to determine if they were recently audible, and
ii) the ability for a guest webcontents to pass any navigation state
changes up to the embedder in order to make them visible at the top
level.

BUG=590656
==========

[wjmaclean, 2016-05-13 20:12:11]

wjmaclean@chromium.org changed reviewers:
+ creis@chromium.org

[wjmaclean, 2016-05-13 20:12:31]

creis@ - small CL, please take a look?

[commit-bot: I haz the power, 2016-05-13 21:35:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 21:35:55]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-05-13 21:54:25]

avi@chromium.org changed reviewers:
+ avi@chromium.org
- creis@chromium.org

[Avi (use Gerrit), 2016-05-13 21:54:26]

Charlie shed some review load; I'm taking this.

LGTM with nits.

https://codereview.chromium.org/1970313002/diff/40001/chrome/browser/apps/gue...
File chrome/browser/apps/guest_view/web_view_browsertest.cc (right):

https://codereview.chromium.org/1970313002/diff/40001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/web_view_browsertest.cc:809: class
MockWasAudibleWebContentsDelegate : public content::WebContentsDelegate {
This isn't a "mock", this is a legitimate delegate. You can call it a
"TestWasAudible..." or a "WasAudible..." but this is all real code.

https://codereview.chromium.org/1970313002/diff/40001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/web_view_browsertest.cc:848:
std::unique_ptr<MockWasAudibleWebContentsDelegate> mock_delegate(
Same "mock" naming issue here.

https://codereview.chromium.org/1970313002/diff/40001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/web_view_browsertest.cc:876: // Wait for audio to
stop (the .mp3 is shorter than the audio stream
unmatched ( in the comment

https://codereview.chromium.org/1970313002/diff/40001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_embedder.h (right):

https://codereview.chromium.org/1970313002/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_embedder.h:114: static bool
GuestRecentlyAudibleCallback(WebContents* guest);
newline after this line

[wjmaclean, 2016-05-13 22:17:23]

Thanks Avi!

https://codereview.chromium.org/1970313002/diff/40001/chrome/browser/apps/gue...
File chrome/browser/apps/guest_view/web_view_browsertest.cc (right):

https://codereview.chromium.org/1970313002/diff/40001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/web_view_browsertest.cc:809: class
MockWasAudibleWebContentsDelegate : public content::WebContentsDelegate {
On 2016/05/13 21:54:26, Avi wrote:
> This isn't a "mock", this is a legitimate delegate. You can call it a
> "TestWasAudible..." or a "WasAudible..." but this is all real code.

Done.

https://codereview.chromium.org/1970313002/diff/40001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/web_view_browsertest.cc:848:
std::unique_ptr<MockWasAudibleWebContentsDelegate> mock_delegate(
On 2016/05/13 21:54:25, Avi wrote:
> Same "mock" naming issue here.

Done.

https://codereview.chromium.org/1970313002/diff/40001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/web_view_browsertest.cc:876: // Wait for audio to
stop (the .mp3 is shorter than the audio stream
On 2016/05/13 21:54:26, Avi wrote:
> unmatched ( in the comment

Done.

https://codereview.chromium.org/1970313002/diff/40001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_embedder.h (right):

https://codereview.chromium.org/1970313002/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_embedder.h:114: static bool
GuestRecentlyAudibleCallback(WebContents* guest);
On 2016/05/13 21:54:26, Avi wrote:
> newline after this line

Done.

[wjmaclean, 2016-05-13 22:17:30]

The CQ bit was checked by wjmaclean@chromium.org

[wjmaclean, 2016-05-13 22:17:30]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1970313002/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-05-13 22:17:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970313002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970313002/60001

[commit-bot: I haz the power, 2016-05-13 23:34:54]

Description was changed from

==========
Audio notification plumbed from guest WebContents up to embedder.

When a guest webcontents is playing audio, there is no way for an
entity interacting with the embedder webcontents to determine this.
This CL adds two things:
i) The ability for WebContentsImpl::WasRecentlyAudible() to query any
guest/child contents to determine if they were recently audible, and
ii) the ability for a guest webcontents to pass any navigation state
changes up to the embedder in order to make them visible at the top
level.

BUG=590656
==========

to

==========
Audio notification plumbed from guest WebContents up to embedder.

When a guest webcontents is playing audio, there is no way for an
entity interacting with the embedder webcontents to determine this.
This CL adds two things:
i) The ability for WebContentsImpl::WasRecentlyAudible() to query any
guest/child contents to determine if they were recently audible, and
ii) the ability for a guest webcontents to pass any navigation state
changes up to the embedder in order to make them visible at the top
level.

BUG=590656
==========

[commit-bot: I haz the power, 2016-05-13 23:34:55]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-13 23:36:56]

Description was changed from

==========
Audio notification plumbed from guest WebContents up to embedder.

When a guest webcontents is playing audio, there is no way for an
entity interacting with the embedder webcontents to determine this.
This CL adds two things:
i) The ability for WebContentsImpl::WasRecentlyAudible() to query any
guest/child contents to determine if they were recently audible, and
ii) the ability for a guest webcontents to pass any navigation state
changes up to the embedder in order to make them visible at the top
level.

BUG=590656
==========

to

==========
Audio notification plumbed from guest WebContents up to embedder.

When a guest webcontents is playing audio, there is no way for an
entity interacting with the embedder webcontents to determine this.
This CL adds two things:
i) The ability for WebContentsImpl::WasRecentlyAudible() to query any
guest/child contents to determine if they were recently audible, and
ii) the ability for a guest webcontents to pass any navigation state
changes up to the embedder in order to make them visible at the top
level.

BUG=590656

Committed: https://crrev.com/1dabf3e34c14d34d9fb262a54cd26c1878eb0034
Cr-Commit-Position: refs/heads/master@{#393689}
==========

[commit-bot: I haz the power, 2016-05-13 23:36:58]

Patchset 3 (id:??) landed as
https://crrev.com/1dabf3e34c14d34d9fb262a54cd26c1878eb0034
Cr-Commit-Position: refs/heads/master@{#393689}