content/browser/browser_plugin/browser_plugin_embedder.h - Issue 1970313002: Audio notification plumbed from guest WebContents up to embedder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.h

Issue 1970313002: Audio notification plumbed from guest WebContents up to embedder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/simple/ping.mp3 ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_embedder.h

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h

index 314053aa8050e89fce31a5ed43670c561d7b6e8e..71f97853fda22fcdbb278f2ec0d1d78e8b8630cd 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.h

+++ b/content/browser/browser_plugin/browser_plugin_embedder.h

@@ -83,6 +83,10 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {

// is returned.

BrowserPluginGuest* GetFullPageGuest();

+ // Polls all guests for this web contents and returns true if any of them

+ // were audible recently.

+ bool WereAnyGuestsRecentlyAudible();

private:

explicit BrowserPluginEmbedder(WebContentsImpl* web_contents);

@@ -107,6 +111,8 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {

WebContents* guest);

static bool StopFindingInGuest(StopFindAction action, WebContents* guest);

+ static bool GuestRecentlyAudibleCallback(WebContents* guest);

// Message handlers.

void OnAttach(RenderFrameHost* render_frame_host,