Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1970153003: Completely detach removed nodes. (Closed)

Created:
4 years, 7 months ago by David Tseng
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Completely detach removed nodes. Scenario: - a client (ChromeVox), saves a reference to an AutomationNode instance - a navigation occurs - a load complete event occurs (reusing the root above) - ChromeVox checks the saved node to see if it is attached to the same root for the load complete event (it is). It therefore decides to stay on that node (which has been "removed"). expected: The node's root property is null. BUG=605375 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/98f218f9c77c4c1255e522b411994a5e813b8d64 Cr-Commit-Position: refs/heads/master@{#393864}

Patch Set 1 : #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js View 1 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 3 chunks +13 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
David Tseng
4 years, 7 months ago (2016-05-12 22:49:02 UTC) #3
dmazzoni
lgtm
4 years, 7 months ago (2016-05-13 20:06:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970153003/40001
4 years, 7 months ago (2016-05-13 20:47:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/169989)
4 years, 7 months ago (2016-05-13 21:50:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970153003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970153003/60001
4 years, 7 months ago (2016-05-16 16:51:03 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-16 18:06:10 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:08:04 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98f218f9c77c4c1255e522b411994a5e813b8d64
Cr-Commit-Position: refs/heads/master@{#393864}

Powered by Google App Engine
This is Rietveld 408576698