chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 1970153003: Completely detach removed nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 1970153003: Completely detach removed nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js ('k') | chrome/renderer/resources/extensions/automation/automation_node.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index 173ff9b11354f0f168c066072eafbb7eb5204238..921e50784e82550a4d0ac8a0a128e1760e4ff5fc 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -913,6 +913,9 @@ Output.prototype = {

* @private

render_: function(range, prevRange, type, buff) {

+ if (prevRange && !prevRange.isValid())

+ prevRange = null;

if (range.isSubNode())

this.subNode_(range, prevRange, type, buff);

else