Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1970153002: Allow Script::FindSharedFunctionInfo to return toplevel functions (Closed)

Created:
4 years, 7 months ago by jgruber1
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow Script::FindSharedFunctionInfo to return toplevel functions We will use this function to find toplevel function infos in an upcoming commit. R=yangguo@chromium.org BUG= Committed: https://crrev.com/b87bdd17456f14ccb8d25c2d5e4989e1c31a4916 Cr-Commit-Position: refs/heads/master@{#36204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970153002/1
4 years, 7 months ago (2016-05-12 10:49:32 UTC) #2
jgruber1
4 years, 7 months ago (2016-05-12 10:54:05 UTC) #3
Yang
On 2016/05/12 10:54:05, jgruber wrote: LGTM.
4 years, 7 months ago (2016-05-12 10:57:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 11:20:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970153002/1
4 years, 7 months ago (2016-05-12 11:22:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 11:24:13 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 11:24:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b87bdd17456f14ccb8d25c2d5e4989e1c31a4916
Cr-Commit-Position: refs/heads/master@{#36204}

Powered by Google App Engine
This is Rietveld 408576698