Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: src/objects.cc

Issue 1970153002: Allow Script::FindSharedFunctionInfo to return toplevel functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 00bd2c18bc6035777310a8252fa8b3f0e7ac178e..06cea50978d92ceaeb661e2e6ee7b316f93244d3 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -12373,9 +12373,6 @@ MaybeHandle<SharedFunctionInfo> Script::FindSharedFunctionInfo(
if (fun->function_token_position() == shared->function_token_position() &&
fun->start_position() == shared->start_position() &&
fun->end_position() == shared->end_position()) {
- // This method is not used to find top-level SharedFunctionInfo objects,
- // verify that above checks are sufficient to distinguish top-level code.
- DCHECK(!shared->is_toplevel());
return Handle<SharedFunctionInfo>(shared);
}
}
« no previous file with comments | « src/compiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698